enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Add Resource Health Status to the Pod Status for Device Plugin and DRA

Open SergeyKanzhelev opened this issue 1 year ago β€’ 58 comments
trafficstars

Enhancement Description

  • One-line enhancement description (can be used as a release note): Expose device health information thru the Pod Status
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4680-add-resource-health-to-pod-status/README.md
  • Discussion Link: https://docs.google.com/document/d/1fOx4PTN61sDv6u9C-t-WpOH8hi2IpenJWPc-Za8UAQE/edit#heading=h.1tvyczqnfmzb (presented at WG Serving and WG Device Management)
  • Primary contact (assignee): @SergeyKanzhelev, @Jpsassine
  • Responsible SIGs: sig/node

/sig node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.31
    • Alpha2 release target (x.y): 1.33
    • Beta release target (x.y): 1.34
    • Stable release target (x.y): 1.34
  • [X] Alpha

    • [X] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4681/
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/126243
    • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/47029
  • [ ] Alpha2 (DRA support)

    • [X] KEP (k/enhancements) update PR(s):
      • 1.32 https://github.com/kubernetes/enhancements/pull/4862
      • 1.33 https://github.com/kubernetes/enhancements/pull/5150
      • 1.34 https://github.com/kubernetes/enhancements/pull/5410, https://github.com/kubernetes/enhancements/pull/5302
    • [ ] Code (k/k) update PR(s):
      • 1.32 https://github.com/kubernetes/kubernetes/pull/128299
      • 1.33 ?
    • [ ] Docs (k/website) update PR(s):
      • [ ] https://github.com/kubernetes/website/pull/48544
      • [ ] https://github.com/kubernetes/website/pull/48547

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

SergeyKanzhelev avatar May 31 '24 18:05 SergeyKanzhelev

Discussed with @mrunalp and we fine to add this to milestone:

/milestone v1.31 /label lead-opted-in /stage alpha

SergeyKanzhelev avatar May 31 '24 20:05 SergeyKanzhelev

Hello, @SergeyKanzhelev πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024..

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we would need to update the following:

  • [ ] Attach the PR link for the KEP with the relevant details along with PRR and get it merged

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

ArkaSaha30 avatar Jun 04 '24 19:06 ArkaSaha30

PRR reviewer here. Is there a KEP to review? Only a few days left till enhancements freeze..

jpbetz avatar Jun 11 '24 19:06 jpbetz

PRR reviewer here. Is there a KEP to review? Only a few days left till enhancements freeze..

Yes, we have polished some imlpementation details, but from PRR perspective it is very straightforward

SergeyKanzhelev avatar Jun 12 '24 21:06 SergeyKanzhelev

Looks like this is the KEP PR: https://github.com/kubernetes/enhancements/pull/4681

richabanker avatar Jun 12 '24 21:06 richabanker

@ArkaSaha30 this KEP can be marked as done for all the checkboxes you listed. Thank you!

SergeyKanzhelev avatar Jun 13 '24 17:06 SergeyKanzhelev

Hello @SergeyKanzhelev πŸ‘‹, 1.31 Enhancements team here,

Now that PR https://github.com/kubernetes/enhancements/pull/4681 has been merged, all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

dipesh-rawat avatar Jun 13 '24 18:06 dipesh-rawat

Hi @SergeyKanzhelev,

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

rashansmith avatar Jun 21 '24 14:06 rashansmith

Hi @SergeyKanzhelev, gentle reminder to raise a draft doc PR against dev-1.31 for this enhancement, before Thursday, June 27, 2024, 18:00 PDT.

Princesso avatar Jun 25 '24 11:06 Princesso

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

rashansmith avatar Jun 28 '24 20:06 rashansmith

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! https://github.com/kubernetes/website/pull/47029

SergeyKanzhelev avatar Jun 29 '24 06:06 SergeyKanzhelev

Hello @SergeyKanzhelev,

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! kubernetes/website#47029

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! kubernetes/website#47029

Hey @SergeyKanzhelev, you currently have a PR for a docs change. To submit a blog post placeholder, create a PR on The website blogpost directory. Here is an example PR. Let me know if you have any questions!

rashansmith avatar Jul 01 '24 21:07 rashansmith

Hey again @SergeyKanzhelev πŸ‘‹, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Regarding this enhancement, it appears that there are currently no open pull requests in the k/k repository related to it.

For this KEP, we would need to do the following:

  • Ensure all PRs to the Kubernetes repo related to your enhancement are linked in the above issue description (for tracking purposes).
  • Ensure all PRs are prepared for merging (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

ArkaSaha30 avatar Jul 08 '24 20:07 ArkaSaha30

Hey again @SergeyKanzhelev πŸ‘‹, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4680#issuecomment-2215256757 still need to be completed. The following PR as per the description still needs to be merged:

  • [x] https://github.com/kubernetes/kubernetes/pull/126243

If you anticipate missing code freeze, you can file an exception request in advance.

ArkaSaha30 avatar Jul 21 '24 17:07 ArkaSaha30

Note for self to add to the beta graduation requirements: https://github.com/kubernetes/kubernetes/pull/126243#discussion_r1688403851

Potential code change to improve stress behavior: https://github.com/kubernetes/kubernetes/pull/126243/files#r1688457694

SergeyKanzhelev avatar Jul 23 '24 17:07 SergeyKanzhelev

@SergeyKanzhelev KEP has been tracked for code freeze after https://github.com/kubernetes/kubernetes/pull/126243 is merged πŸŽ‰

sreeram-venkitesh avatar Jul 24 '24 05:07 sreeram-venkitesh

Hello @SergeyKanzhelev, Awesome job on passing code freeze.

I'm immediately switching to ⚠️Risk for Doc Freeze because it is very overdue to have documentation ready to review. (the deadline was last week, Tuesday, July 16th, 2024 18:00 PST and the diff on the website PR only has "TODO" in it) SIG Release Docs has reached out but we haven't heard a response. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ASAP.

❗️This is important because the next deadline is the Doc Freeze on Tuesday 30th July 2024, after which will require an approved exception for this feature to ship with 1.31 if docs aren't merged. We appreciate your prompt attention to getting these docs ready for review, because with that review, SIG Docs will need to review and approve per project standards, along with a technical review from your SIG. Any suggested changes must be addressed, reviewed again, approved, and merged. SIG Release is available to help facilitate these activities but there's limited time left!

Thanks for your cooperation. πŸš€

drewhagen avatar Jul 24 '24 14:07 drewhagen

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board πŸ˜€. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

tjons avatar Sep 16 '24 12:09 tjons

/milestone v1.32 /label lead-opted-in

haircommander avatar Sep 17 '24 18:09 haircommander

Hello @SergeyKanzhelev πŸ‘‹, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha2 for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

shecodesmagic avatar Sep 30 '24 15:09 shecodesmagic

@SergeyKanzhelev I'm part of the SIG-NODE KEPs wrangler team for this release. It looks like the plan is to keep this feature at Alpha2 for this release. Is that the correct?

sohankunkerkar avatar Oct 02 '24 15:10 sohankunkerkar

@SergeyKanzhelev can you please update the KEP alpha description with the PRs that are part of this milestone?

kannon92 avatar Oct 03 '24 16:10 kannon92

@shecodesmagic I believe all checkboxes are satisfied now on this KEP. Please let me know if anything else is needed to mark this as tracked

SergeyKanzhelev avatar Oct 10 '24 20:10 SergeyKanzhelev

@SergeyKanzhelev with all requirements met, this enhancement is now tracked for enhancements freeze! πŸš€

tjons avatar Oct 10 '24 22:10 tjons

Hello @SergeyKanzhelev πŸ‘‹ from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

rashansmith avatar Oct 14 '24 19:10 rashansmith

Hello @SergeyKanzhelev πŸ‘‹ 1.32 Docs Shadow here.

Does this enhancement work planned for 1.32 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against the dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

hacktivist123 avatar Oct 15 '24 15:10 hacktivist123

Hello, @SergeyKanzhelev πŸ‘‹ 1.32 Docs Shadow here.

This is just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs:

The deadline for this is Thursday, Oct 24 at 18:00 PDT.

Thanks! πŸš€

hacktivist123 avatar Oct 18 '24 12:10 hacktivist123

website repository

Hello @SergeyKanzhelev πŸ‘‹ from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Hello @SergeyKanzhelev!

This is a reminder for the feature blog post!

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Please feel free to reach out if you have any questions!

rashansmith avatar Oct 27 '24 20:10 rashansmith

Hello @SergeyKanzhelev :wave:, Enhancements team here (again 😁 )

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024. Please update the issue description above and add all the PRs to the Kubernetes repo that are related to your enhancement (for tracking purposes).

It seems to me that all related PRs are merged already. Please let me know if that is not the case. I will mark this enhancement as tracked for code freeze for the v1.32 Code Freeze!

As always, we are here to help if any questions come up. Thanks!

shecodesmagic avatar Oct 30 '24 00:10 shecodesmagic

/wg device-management

pohly avatar Nov 19 '24 16:11 pohly