enhancements
enhancements copied to clipboard
kubernetes
KEP-4322: Add cluster inventory definition
- One-line PR description: Add the definition of a cluster Inventory and some notes on how it should be consumed.
- Issue link:
- Other comments:
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: ryanzhang-oss / name: Ryan Zhang (02ec2c27d120071aad20a136a9700bed2949e1c0, 5f2df982896af2be8d49a710bd039b001bb792cb, 340745dc2f2ed1f8752bfa7682d1f9ce9dff3397)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @ryanzhang-oss!
It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/enhancements has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @ryanzhang-oss. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ryanzhang-oss: The following test failed, say
/retestto rerun all failed tests or/retest-requiredto rerun all mandatory failed tests:
Test name Commit Details Required Rerun command pull-enhancements-verify 04f03c31a212b9ccfca77233066e36d7e34891fd link true /test pull-enhancements-verifyFull PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@ryanzhang-oss please address the issue
Summary of the error
Table of content not up to date. Did you run 'make update-toc' ?
Looks like the last commit is from a non verified source, could you fix that @ryanzhang-oss
@mikeshng: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: corentone, JeremyOT, mikemorris, mikeshng, ryanzhang-oss
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~keps/sig-multicluster/OWNERS~~ [JeremyOT]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment