enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-4322: rename API to "Cluster Profile" and add alternative section

Open mikeshng opened this issue 1 year ago • 12 comments
trafficstars

  • One-line PR description: Update KEP-4322 by renaming API to "Cluster Profile" and adding an alternative description.
  • Issue link: https://github.com/kubernetes/enhancements/issues/4322
  • Other comments: The decision to rename the API to "Cluster Profile" was not based on personal opinion but on consensus from the SIG-MC community, through discussions in meetings, open votes, and at KubeCon EU 2024.

/sig multicluster

CC @qiujian16 @JeremyOT @dixudx @ryanzhang-oss

mikeshng avatar Mar 04 '24 20:03 mikeshng

Welcome @mikeshng!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 04 '24 20:03 k8s-ci-robot

Hi @mikeshng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 04 '24 20:03 k8s-ci-robot

/ok-to-test

skitt avatar Apr 16 '24 14:04 skitt

++

ArangoGutierrez avatar Apr 16 '24 16:04 ArangoGutierrez

+1

qiujian16 avatar Apr 17 '24 04:04 qiujian16

/lgtm

skitt avatar Apr 17 '24 07:04 skitt

/assign @JeremyOT

skitt avatar Apr 17 '24 07:04 skitt

/lgtm

ryanzhang-oss avatar May 02 '24 19:05 ryanzhang-oss

@ryanzhang-oss: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 02 '24 19:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArangoGutierrez, mikeshng Once this PR has been reviewed and has the lgtm label, please ask for approval from jeremyot. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 02 '24 19:05 k8s-ci-robot

Ready for review @JeremyOT

ArangoGutierrez avatar May 03 '24 08:05 ArangoGutierrez