enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-1847: promote autoremove-statefulset-pvcs to GA

Open carlory opened this issue 2 years ago • 13 comments

  • One-line PR description: promote autoremove-statefulset-pvcs to GA
  • Issue link: #1847
  • Other comments:

carlory avatar Sep 08 '23 07:09 carlory

/cc @mattcary

carlory avatar Sep 08 '23 07:09 carlory

/cc @msau42

Thanks, we're discussing the feature readiness.

mattcary avatar Sep 08 '23 16:09 mattcary

Thanks, we're discussing the feature readiness.

@mattcary any results from the discussions?

soltysh avatar Sep 29 '23 09:09 soltysh

Sorry for the delay in reply.

We don't have any data on usage -- we had thought we could look at kube state metrics, but it turns out they're filtered in GKE and we don't have usage stats for this feature.

So we can go off of issues surrounding the feature, which don't seem to be many.

I'm not sure of the bar we have for GA.

mattcary avatar Oct 04 '23 17:10 mattcary

I'm not sure of the bar we have for GA.

If that's the case, I'd rather not rush this, but let it soak for a bit more.

soltysh avatar Oct 04 '23 17:10 soltysh

Ok, thanks, I agree. I should have some time to figure out how to get fleet level statistics for usage, that will make me feel much more confident about it.

mattcary avatar Oct 04 '23 18:10 mattcary

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 22 '24 01:01 k8s-triage-robot

FYI, we are going to soak the changes in https://github.com/kubernetes/kubernetes/pull/122499 for a release and then go GA if all is good (I guess that's 1.31).

mattcary avatar Jan 22 '24 17:01 mattcary

/hold

carlory avatar Jan 23 '24 06:01 carlory

FYI, we are going to soak the changes in kubernetes/kubernetes#122499 for a release and then go GA if all is good (I guess that's 1.31).

Great news!

soltysh avatar Jan 23 '24 09:01 soltysh

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 22 '24 09:02 k8s-triage-robot

/remove-lifecycle stale

mattcary avatar Mar 13 '24 20:03 mattcary

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Apr 12 '24 21:04 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 12 '24 21:04 k8s-ci-robot

/reopen

carlory avatar Apr 16 '24 07:04 carlory

@carlory: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 16 '24 07:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory Once this PR has been reviewed and has the lgtm label, please assign janetkuo, jpbetz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 16 '24 07:04 k8s-ci-robot