enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Add job creation timestamp to job annotations

Open helayoty opened this issue 2 years ago โ€ข 30 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add new annotation JobCreationTimestampAnnotation to the batch API.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/4026-crojob-scheduled-timestamp-annotation/README.md
  • Discussion Link: https://github.com/kubernetes/kubernetes/issues/108609
  • Primary contact (assignee): @helayoty @soltysh
  • Responsible SIGs: sig-apps
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): N/A
    • Beta release target (x.y): 1.28
    • Stable release target (x.y): 1.32

Note: We will release the feature directly in the Beta state since there is no benefit in having an alpha release, as we are simply adding a new annotation which is very little risk (unlike removing an existing one).

  • [x] Beta
    • [X] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4027
    • [X] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/118137
    • [X] Docs
      • [X] Update k/website on the dev-1.28 branch PR(s): https://github.com/kubernetes/website/pull/41857
  • [ ] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4868
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/127589
    • [ ] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/48498

helayoty avatar May 22 '23 20:05 helayoty

/sig apps /assign

helayoty avatar May 22 '23 20:05 helayoty

/stage beta /milestone v1.28 /label lead-opted-in

soltysh avatar May 30 '23 11:05 soltysh

Hi @helayoty ๐Ÿ‘‹, Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.28
  • [x] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like https://github.com/kubernetes/enhancements/pull/4027 will address some of these issues.

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar May 30 '23 23:05 npolshakova

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire

@npolshakova This section requires to have reviewers from the prod-readiness-approvers team which I already added to the reviewers/approvals list.

helayoty avatar May 31 '23 19:05 helayoty

Hi @helayoty, looks like now that the PRR is approved and https://github.com/kubernetes/enhancements/pull/4027 has gone in this enhancement is now tracked for 1.28!

npolshakova avatar Jun 14 '23 19:06 npolshakova

Hello @helayoty :wave:, 1.28 Docs Lead here.

Could you please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Rishit-dagli avatar Jul 01 '23 09:07 Rishit-dagli

Hello @helayoty ๐Ÿ‘‹, 1.28 Docs Lead here.

Could you please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @Rishit-dagli , PR has been created. https://github.com/kubernetes/website/pull/41857

helayoty avatar Jul 03 '23 15:07 helayoty

BTW, there is a typo in the KEP path: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/4026-crojob-scheduled-timestamp-annotation

sftim avatar Jul 06 '23 21:07 sftim

Hey again @helayoty :wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Hereโ€™s the enhancementโ€™s state for the upcoming code freeze:

  • [x] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • [x] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.
    • https://github.com/kubernetes/kubernetes/pull/118137

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

npolshakova avatar Jul 11 '23 21:07 npolshakova

@npolshakova all the PRs are listed in the issue description, we try to keep up-to-date, the only one remaining PR is docs https://github.com/kubernetes/website/pull/41857 but that shouldn't block atm.

soltysh avatar Jul 12 '23 10:07 soltysh

Hey @helayoty ๐Ÿ‘‹ Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/118137 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze!

Atharva-Shinde avatar Jul 19 '23 03:07 Atharva-Shinde

/remove-label lead-opted-in

npolshakova avatar Aug 27 '23 22:08 npolshakova

Hello ๐Ÿ‘‹ 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

salehsedghpour avatar Jan 16 '24 23:01 salehsedghpour

@helayoty are you able to work on graduating this to GA in 1.30?

atiratree avatar Jan 19 '24 15:01 atiratree

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 18 '24 16:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 18 '24 16:05 k8s-triage-robot

/remove-lifecycle rotten

helayoty avatar May 20 '24 17:05 helayoty

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 18 '24 18:08 k8s-triage-robot

/remove-lifecycle rotten

helayoty avatar Aug 20 '24 02:08 helayoty

@helayoty any plans to get this GA-ed in 1.32?

soltysh avatar Sep 16 '24 14:09 soltysh

/remove-lifecycle stale

soltysh avatar Sep 24 '24 09:09 soltysh

I haven't heard from Heba, but I'd like to push this forward especially that it's rather simple feature and comes very handy.

/label lead-opted-in /milestone v1.32 /stage stable

soltysh avatar Sep 24 '24 09:09 soltysh

Hello @helayoty ๐Ÿ‘‹, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] KEP readme has up-to-date graduation criteria
  • [x] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

shecodesmagic avatar Sep 28 '24 20:09 shecodesmagic

@shecodesmagic https://github.com/kubernetes/enhancements/pull/4868 should handle all of the above.

soltysh avatar Sep 30 '24 10:09 soltysh

@soltysh sounds good. Once that's merged we can mark it as tracked.

shecodesmagic avatar Sep 30 '24 12:09 shecodesmagic

@soltysh Hereโ€™s where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.32. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [X] KEP readme has up-to-date graduation criteria.
  • [X] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. ๐Ÿš€

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

shecodesmagic avatar Oct 09 '24 00:10 shecodesmagic

Hello @helayoty :wave:, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

michellengnx avatar Oct 11 '24 16:10 michellengnx

Hello @helayoty ๐Ÿ‘‹ from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

rashansmith avatar Oct 14 '24 19:10 rashansmith

Hello @helayoty ๐Ÿ‘‹, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Hello @helayoty ๐Ÿ‘‹,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is 4 days away at Thursday October 24, 2024 18:00 PDT.

Thanks, Michelle

michellengnx avatar Oct 21 '24 03:10 michellengnx

Draft opened at https://github.com/kubernetes/website/pull/48498

soltysh avatar Oct 22 '24 17:10 soltysh