enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Graduate DeviceManager to GA

Open swatisehgal opened this issue 3 years ago • 7 comments
trafficstars

Enhancement Description

  • One-line enhancement description (can be used as a release note): graduate DeviceManager to GA
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/3574
  • Discussion Link: SIG Node - 1.26 Planning held as part of SIG Node weekly meetings on 20th September 2022.
  • Primary contact (assignee): @swatisehgal
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target: 1.8
    • Beta release target: 1.10
    • Stable release target: 1.26
  • [X] Stable
    • [X] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3574
    • [X] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/112980
    • [X] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/37273

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

Addtional References:

  1. Original Issue: https://github.com/kubernetes/enhancements/issues/368
  2. Original Proposal: https://github.com/kubernetes/community/pull/695 currently present here: https://github.com/kubernetes/design-proposals-archive/blob/main/resource-management/device-plugin.md
  3. Device Plugin Work Tracker Issues: https://github.com/kubernetes/kubernetes/issues/53497 and https://github.com/kubernetes/kubernetes/issues/56649
  4. Beta Graduation: https://github.com/kubernetes/kubernetes/pull/60170

swatisehgal avatar Oct 02 '22 08:10 swatisehgal

/sig node

swatisehgal avatar Oct 02 '22 08:10 swatisehgal

/milestone v1.26 /label lead-opted-in (Doing this on behalf of sig-node https://kubernetes.slack.com/archives/C0BP8PW9G/p1664788920990529)

marosset avatar Oct 03 '22 17:10 marosset

/stage stable /label tracked/yes

rhockenbury avatar Oct 03 '22 21:10 rhockenbury

Hello @swatisehgal 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.26
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like https://github.com/kubernetes/enhancements/issues/3574 will address all of these requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

marosset avatar Oct 03 '22 23:10 marosset

With https://github.com/kubernetes/enhancements/pull/3574 merged this enhancement is tracked for the v1.26 release. Thank you!

marosset avatar Oct 06 '22 17:10 marosset

I recommend cracking on with early work on a docs update so that these are GA quality (or have PRs open to make them be) by the appropriate review deadline.

sftim avatar Oct 10 '22 17:10 sftim

@sftim Sure, will do.

swatisehgal avatar Oct 11 '22 09:10 swatisehgal

Hi @swatisehgal 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [x] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before the code freeze. Please link any other PRs that should be tracked beyond the below PR:

  • https://github.com/kubernetes/kubernetes/pull/112980

As always, we are here to help should questions come up. Thanks!

ruheenaansari34 avatar Nov 02 '22 14:11 ruheenaansari34

For this enhancement, it looks like the k/k PR https://github.com/kubernetes/kubernetes/pull/112980 is closed 🎉. If you do have any other k/k PRs open, please link them to this issue.

ruheenaansari34 avatar Nov 07 '22 21:11 ruheenaansari34

Hello @swatisehgal 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

krol3 avatar Nov 09 '22 13:11 krol3

Hi @swatisehgal since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3573-device-plugin/kep.yaml setting the status to implemented and then close this issue. Thanks!

marosset avatar Dec 12 '22 23:12 marosset

Maybe the title of this issue should be “Add Device Manager to kubelet”

sftim avatar Dec 22 '22 20:12 sftim

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 24 '23 15:04 k8s-triage-robot

Send https://github.com/kubernetes/enhancements/pull/3987 that will close this issue

SergeyKanzhelev avatar May 05 '23 21:05 SergeyKanzhelev