enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

WIP: DNM: Hack on kep 3085

Open thockin opened this issue 3 years ago • 6 comments

I didn't get to review 3085 and there is no good way to add comments to a merged KEP, so I am trying this approach.

thockin avatar Sep 09 '22 20:09 thockin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thockin Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval by writing /assign @derekwaynecarr in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 09 '22 20:09 k8s-ci-robot

@thockin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 23 '22 05:09 k8s-ci-robot

FTR: I am not expecting dramatic action on 1.26, given timing, but this CAN NOT proceed to beta without discussion.

thockin avatar Sep 29 '22 17:09 thockin

ack, @thockin. Appreciate the review and the thoughts. I will DM to find a time to meet (virtually or during Kubecon).

I really like the idea of a list of "steps" with timestamps. Similar to conditions but actually designed for this, no baggage. We indeed tried to force-fit our requirement into pod conditions mainly based on the existing Initialized pod condition but deciding not to alter that for compatibility concerns.

ddebroy avatar Sep 29 '22 19:09 ddebroy

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 28 '22 19:12 k8s-triage-robot

@ddebroy what did we decide to do about this?

thockin avatar Jan 14 '23 00:01 thockin