enhancements KEP-3461: Add QoS Resource Manager to Extend Resource Allocation Policies

KEP-3461: Add QoS Resource Manager to Extend Resource Allocation Policies

One-line PR description: Add a new component in Kubelet ecosystem to dynamically adjust resource allocation with more flexibility and extensibility, to support QoS-aware and Topology-aware systems

Issue link: https://github.com/kubernetes/enhancements/issues/3461

Aug 16 '22 08:08 waynepeking348

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: waynepeking348 / name: shaowei (eebdbf6dcdb4bd4d71115873e8b740e9d5561857)

Aug 16 '22 08:08 linux-foundation-easycla[bot]

Welcome @waynepeking348!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

Aug 16 '22 08:08 k8s-ci-robot

Hi @waynepeking348. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Aug 16 '22 08:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: waynepeking348 Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval by writing /assign @dchen1107 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

keps/sig-node/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Aug 16 '22 08:08 k8s-ci-robot

/cc @vinaykul

Aug 20 '22 14:08 vinaykul

@vinaykul: GitHub didn't allow me to request PR reviews from the following users: vinaykul.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vinaykul

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Aug 20 '22 14:08 k8s-ci-robot

With the recently accepted KEP linked below, general resource management is moving towards a more dynamic model going forward. One will no longer be limited to providing a simple "count" of their resources. Driver implementors will be able to express the interface for requesting a set of resources however they like. There are already plans for writing drivers for CPU and Hugepages in this new framework (in addition to the plethora of other devices likes GPUs, NICs, etc.).

https://github.com/kubernetes/enhancements/pull/3064

Can you comment on how this proposal plans to integrate / interoperate with this new model?

Aug 22 '22 07:08 klueska

With the recently accepted KEP linked below, general resource management is moving towards a more dynamic model going forward. One will no longer be limited to providing a simple "count" of their resources. Driver implementors will be able to express the interface for requesting a set of resources however they like. There are already plans for writing drivers for CPU and Hugepages in this new framework (in addition to the plethora of other devices likes GPUs, NICs, etc.).

#3064

Can you comment on how this proposal plans to integrate / interoperate with this new model?

thx~ we read the detailed KEP as well as the alpha pr for DRA, those two KEP have a lot in similarity indeed, but we still got some got a few questions

we notice that DRA works as a topology manager hint provider, but it seems that DRA manager actually don't provide numa-affinity info for now, and the DRA plugin protocol doesn't contain numa-related info in Response either; we would like to what's the detailed plan for this functionality
you mentioned that you plan to writing drivers for CPU and Hugepages in DRA framework, and but we don't know how you plan to do this in detail, since the native scheduler already counts on Native Resources (cpu, memory, etc.) as predicated and prioritized inputs.
for now, only CDI can be injected in annotation for CRI, but if we want to set OCI Property for container (for instance, cpuset.mems, and so on), will it be extensible？
will you plan to support reconciling logic in DRA manager? since in real production environment, we may need to adjust resource allocation results periodically based on running states (instead of static allocation only)

Aug 29 '22 09:08 waynepeking348

@waynepeking348 As a reminder (and as noted on your issue) we generally ask that you discuss your KEP idea with the sponsoring sig prior to opening a PR in this repo. You did not include a Discussion Link in your issue. Please either provide one on the issue or contact sig node via their meetings/slack/mailing lists etc... to discuss your idea.

Sep 16 '22 00:09 kikisdeliveryservice

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Dec 15 '22 01:12 k8s-triage-robot

/ok-to-test

Dec 23 '22 09:12 bart0sh

@waynepeking348: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-enhancements-test	eebdbf6dcdb4bd4d71115873e8b740e9d5561857	link	true	`/test pull-enhancements-test`
pull-enhancements-verify	eebdbf6dcdb4bd4d71115873e8b740e9d5561857	link	true	`/test pull-enhancements-verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Dec 23 '22 09:12 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Jan 22 '23 09:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Feb 21 '23 10:02 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Feb 21 '23 10:02 k8s-ci-robot