enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

KEP-3314: Changed Block Tracking With CSI VolumeSnapshotDelta

Open ihcsim opened this issue 3 years ago • 6 comments

Signed-off-by: Ivan Sim [email protected]

  • One-line PR description: Add new KEP for changed block tracking (CBT)
  • Issue link: #3314
  • Other comments:

ihcsim avatar Jun 08 '22 21:06 ihcsim

@ihcsim There is a mismatch in the callbackURL format used in DifferentialSnapshot status example in cbt-step-02.png i.e (https://stream-uri:port-number/cr-namespace/cr-name) and cbt-step-03.png which is (https://stream-uri:port-number/custom-resource-uid).

PrasadG193 avatar Jun 09 '22 12:06 PrasadG193

@ihcsim Thanks..! I have few review comments and will pass one more round soon..

humblec avatar Jun 09 '22 16:06 humblec

/retest

ihcsim avatar Jun 10 '22 17:06 ihcsim

/assign @msau42

xing-yang avatar Jun 22 '22 13:06 xing-yang

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ihcsim Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval by writing /assign @johnbelamaric in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 01 '22 16:09 k8s-ci-robot

I am not sure about usage of the aggregated API server and "virtual resources" there - I can see it is possible to implement it this way, I just don't know if it's the best option. The alternatives are well documented, so we can discuss the details in the API review. The interface between a storage backend, a CSI driver and aggregated API server looks OK.

From storage point of view, this KEP makes sense and is implementable. /lgtm

I let @msau42 approve (or ping me on slack).

jsafrane avatar Oct 06 '22 09:10 jsafrane

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ihcsim Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval by writing /assign @johnbelamaric in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 15 '22 17:12 k8s-ci-robot

Looking at commits since my last review, PRR should still be good on this. I just can't do the prow approval until I see the SIG approval.

johnbelamaric avatar Feb 07 '23 19:02 johnbelamaric

@thockin @johnbelamaric Thanks for the feedback. The working group still has some concerns on the proposed aggregated API server approach. There is still some work to be done here.

ihcsim avatar Feb 07 '23 22:02 ihcsim

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 22 '23 16:05 k8s-triage-robot

/remove-lifecycle stale

xing-yang avatar May 22 '23 17:05 xing-yang

Superseded by https://github.com/kubernetes/enhancements/pull/4082, due to authorship changes.

ihcsim avatar Jun 12 '23 21:06 ihcsim