enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Pod conditions around completion of pod sandbox creation and pod networking configuration

Open ddebroy opened this issue 3 years ago โ€ข 20 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Surface pod conditions around completion of pod sandbox creation marked by successful network configuration for the pod.

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/3087

  • Discussion Link: SIG Node Agenda [Jan 4th, 2022]

  • Primary contact (assignee): @ddebroy

  • Responsible SIGs: sig-node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.25
    • Beta release target (x.y): 1.26
    • Stable release target (x.y):
  • [x] Alpha

    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3087
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/111358
    • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/35704
  • [ ] Beta

    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

ddebroy avatar Dec 14 '21 17:12 ddebroy

/sig node

ddebroy avatar Dec 14 '21 17:12 ddebroy

Hi @ddebroy! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Hereโ€™s where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo. - INCLUDED IN PR #3087
  • [ ] KEP status is marked as implementable for latest-milestone: 1.24 - INCLUDED IN PR #3087
  • [ ] KEP has a test plan section filled out. - INCLUDED IN PR #3087
  • [ ] KEP has up to date graduation criteria. - INCLUDED IN PR #3087
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. - INCLUDED IN PR #3087

Please plan to merge #3087 by enhancements freeze to complete the above items. The status of this enhancement is at risk. Thanks!

rhockenbury avatar Jan 20 '22 22:01 rhockenbury

PRR for the KEP is complete for 1.24. Waiting on final reviews from sig-node.

ddebroy avatar Feb 01 '22 17:02 ddebroy

The Enhancements Freeze is now in effect and this enhancement is removed from the release. Please feel free to file an exception.

/milestone clear

gracenng avatar Feb 04 '22 02:02 gracenng

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 05 '22 03:05 k8s-triage-robot

/remove-lifecycle stale

ddebroy avatar May 05 '22 16:05 ddebroy

/milestone v1.25

Priyankasaggu11929 avatar Jun 10 '22 02:06 Priyankasaggu11929

Hello @ddebroy ๐Ÿ‘‹, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [ ] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the open KEP PR https://github.com/kubernetes/enhancements/pull/3087 for following & get it merged by Enhancements Freeze:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Priyankasaggu11929 avatar Jun 10 '22 08:06 Priyankasaggu11929

I have updated the Test Plan section as recommended based on the latest template pointed out above.

ddebroy avatar Jun 13 '22 18:06 ddebroy

Thanks for the quick update, @ddebroy ๐Ÿ™‚

Priyankasaggu11929 avatar Jun 14 '22 05:06 Priyankasaggu11929

With KEP PR https://github.com/kubernetes/enhancements/pull/3087 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! ๐Ÿ™‚

Priyankasaggu11929 avatar Jun 23 '22 05:06 Priyankasaggu11929

Hello @ddebroy ๐Ÿ‘‹, 1.25 Release Docs Shadow here.

This enhancement is marked as โ€˜Needs Docsโ€™ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.โ€จ

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

didicodes avatar Jul 13 '22 13:07 didicodes

Hi @ddebroy ๐Ÿ‘‹

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.
    • https://github.com/kubernetes/kubernetes/pull/111358

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

parul5sahoo avatar Jul 22 '22 14:07 parul5sahoo

Hi @ddebroy :wave:

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022, which is in two days.

please ensure that you have the following PR(s) merged before that :-

  • https://github.com/kubernetes/kubernetes/pull/111358

Thanks

parul5sahoo avatar Aug 01 '22 03:08 parul5sahoo

https://github.com/kubernetes/kubernetes/pull/111358 has merged!

ddebroy avatar Aug 01 '22 20:08 ddebroy

Thanks @ddebroy now the status is marked as tracked.

parul5sahoo avatar Aug 02 '22 07:08 parul5sahoo

excuse me. If this Condition is added, how can I distinguish whether it meets the PodHasNetwork condition for the existing Pod? @ddebroy

lujinda avatar Sep 14 '22 00:09 lujinda

hi @lujinda can you please clarify your question (potentially with an example) a bit? Are you referring to how to find out if the condition was set?

ddebroy avatar Sep 15 '22 16:09 ddebroy

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 14 '22 17:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 13 '23 17:01 k8s-triage-robot

/remove-lifecycle rotten

ddebroy avatar Jan 24 '23 17:01 ddebroy

/label lead-opted-in

dchen1107 avatar Feb 01 '23 00:02 dchen1107

/milestone v1.27

dchen1107 avatar Feb 01 '23 00:02 dchen1107

@dchen1107: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 01 '23 00:02 k8s-ci-robot

/label lead-opted-in

mrunalp avatar Feb 01 '23 21:02 mrunalp

/stage beta

ddebroy avatar Feb 01 '23 21:02 ddebroy

/kind feature

ddebroy avatar Feb 01 '23 22:02 ddebroy

Hello @ddebroy ๐Ÿ‘‹, 1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.27
  • [x] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like https://github.com/kubernetes/enhancements/pull/3778 will address most of these issues.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar Feb 06 '23 15:02 npolshakova

@npolshakova with https://github.com/kubernetes/enhancements/pull/3778 merged with PRR approval for Beta, can we consider this feature as ready for the 1.27 Freeze?

ddebroy avatar Feb 09 '23 16:02 ddebroy

Looks good!

/remove-label tracked/no /label tracked/yes

npolshakova avatar Feb 09 '23 20:02 npolshakova