enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

NetworkPolicy port range

Open rikatz opened this issue 5 years ago β€’ 38 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allow a Network Policy to contemplate a set of ports in a single rule.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2079-network-policy-port-range
  • Discussion Link: https://www.youtube.com/watch?v=yX1nFb3DS3A&list=PL69nYSiGNLP2E8vmnqo5MwPOY25sDWIxb Minute 29:00
  • Primary contact (assignee): @rikatz
  • Responsible SIGs: Network
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) - v1.21
    • Beta release target (x.y) - v1.22
    • Stable release target (x.y) - TBD

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig network

rikatz avatar Oct 06 '20 12:10 rikatz

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 04 '21 17:01 fejta-bot

/remove-lifecycle stale

rikatz avatar Jan 04 '21 17:01 rikatz

/lifecycle active

rikatz avatar Jan 26 '21 13:01 rikatz

This enhancement has met all the requirements for the enhancement freeze πŸ‘

annajung avatar Feb 09 '21 20:02 annajung

Hi @rikatz,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 β€” Code Freeze
  • Tuesday, March 16th: Week 10 β€” Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

JamesLaverack avatar Feb 19 '21 23:02 JamesLaverack

Hi @rikatz

Enhancements team is currently tracking the following PRs

  • https://github.com/kubernetes/kubernetes/pull/97058

As this PR is merged, can we mark this enhancement complete for code freeze or do you have other PR(s) that are being worked on as part of the release?

JamesLaverack avatar Mar 02 '21 11:03 JamesLaverack

@JamesLaverack :wave:

Yes,this can be marked as done. I'm just working on the docs here: https://github.com/kubernetes/website/pull/26714

rikatz avatar Mar 02 '21 12:03 rikatz

/milestone v1.22 /stage beta

JamesLaverack avatar May 01 '21 01:05 JamesLaverack

Hey @rikatz, 1.22 Enhancements Lead here.

I've got a few questions about your KEP:

  • Can you update the latest-milestone key in your kep.yaml to `"v1.22".

Additionally, if you are planning to graduate this feature to Beta (which is my current assumption, please tell me if I'm wrong) can you also:

  • Set the stage key in your kep.yaml to be beta, along with setting milestones.beta to be "v1.22".
  • We also require an approved beta-stage production readiness review.

Let me know if you have any questions.

JamesLaverack avatar May 11 '21 01:05 JamesLaverack

Hi @JamesLaverack

Yes, we intend to move this to beta in v1.22. There's going to be a slight change in graduation policy criteria (already discussed with the sig-net chairs in mailing list).

I'll move this forward during this week/end

rikatz avatar May 11 '21 12:05 rikatz

Hey @rikatz. Okay, if you're going beta then the requirements are as above.

Note that enhancements freeze is in just over two days at 23:59:59 PDT on Thursday 13th May. If your updates are not complete by then this would require an exception.

JamesLaverack avatar May 11 '21 12:05 JamesLaverack

@rikatz - you also need to update PRR questionaire and get PRR approval.

wojtek-t avatar May 11 '21 13:05 wojtek-t

OK thanks folks!

I've added a PR moving to Beta (https://github.com/kubernetes/enhancements/pull/2709) and hope this is ok and inside the window to change it!

rikatz avatar May 11 '21 13:05 rikatz

…and hope this is ok and inside the window to change it!

Of course, as long as the required changes are approved and merge by enhancements freeze (23:59:59 PDT on Thursday 13th May) then you're good. :)

JamesLaverack avatar May 12 '21 01:05 JamesLaverack

With https://github.com/kubernetes/enhancements/pull/2709 merged this enhancement is complete for 1.22 enhancements freeze.

JamesLaverack avatar May 13 '21 23:05 JamesLaverack

Hello @rikatz πŸ‘‹ , 1.22 Docs Shadow here.

This enhancement is marked as Needs Docs for 1.22 release. Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

ritpanjw avatar May 19 '21 19:05 ritpanjw

Hey @rikatz, can you confirm if https://github.com/kubernetes/kubernetes/pull/102834 is the only k/k PR for this enhancement in v1.22?

JamesLaverack avatar Jun 23 '21 01:06 JamesLaverack

Hey @JamesLaverack sorry for the delay ;/

Yes that is the only PR. I need to update the feature gate status on the docs, will do that tomorrow!

Thanks

rikatz avatar Jun 23 '21 01:06 rikatz

sorry for the delay ;/

I only commented two minutes ago, I think you're good. πŸ˜„

Yes that is the only PR

Great, thank you for confirming.

JamesLaverack avatar Jun 23 '21 01:06 JamesLaverack

Hello @rikatz πŸ‘‹ , 1.22 Docs Shadow here.

This enhancement is marked as Needs Docs for 1.22 release. Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@rikatz Friendly reminder about the upcoming docs placeholder PR deadline on Fri July 9, 11:59 PM PDT. Please create a placeholder PR by then, thanks!

PI-Victor avatar Jul 06 '21 20:07 PI-Victor

Looking at this for 1.23: I'd love to understand more of what makes it hard for implementations (Openshift and Cilium and ...) and if there's a better way to approach this.

I kind of like the idea of adding status to NetPol, to let controller(s) indicate support, but that's a big thing to throw into this KEP. How would you feel about opening a new KEP to explore the minimum status required to expose this?

thockin avatar Sep 03 '21 19:09 thockin

I will open a new KEP to add status to NetPol, in a way of allowing controllers / CNIs to let the user know if the policy was processed correctly (and features) but not if the Netpol was properly implemented in nodes, sounds good?

Will use this issue + the endPort range as the "discussion" that triggered the new KEP :)

rikatz avatar Sep 05 '21 18:09 rikatz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 04 '21 19:12 k8s-triage-robot

/lifecycle frozen

rikatz avatar Dec 09 '21 19:12 rikatz

@thockin we need to talk about this one :)

rikatz avatar Dec 30 '21 00:12 rikatz

@thockin I missed the last sig-net meeting (forgot...) but watched later. As I understood, should we promote this to GA? If so I will probably have some time to work on the KEP during weekend.

Tks

rikatz avatar Jan 28 '22 00:01 rikatz

Hi @rikatz ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting GA for 1.24 Here’s where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for this release with latest-milestone: 1.24
  • [x] KEP has a test plan section filled out.
  • [x] KEP has up to date graduation criteria.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk. Please update this issue description to reflect enhancements target Thanks!

gracenng avatar Jan 29 '22 19:01 gracenng

Hi @gracenng

Latest actions were taken in PR https://github.com/kubernetes/enhancements/pull/2883

Just waiting to get merged

Tks

rikatz avatar Jan 30 '22 13:01 rikatz

Added to spreadsheet for 1.25

thockin avatar Jun 20 '22 21:06 thockin

Hello @rikatz πŸ‘‹, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PT on Thursday June 23, 2022, which is just over 3 days from now.

For note, This enhancement is targeting for stage stable for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [X] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The open PR https://github.com/kubernetes/enhancements/pull/2883 is addressing all the unchecked items above. Please plan to get it merged by the Enhancements Freeze.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Priyankasaggu11929 avatar Jun 21 '22 07:06 Priyankasaggu11929