enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard
verified publisher icon kubernetes

kube-apiserver identity

Open roycaihw opened this issue 5 years ago • 44 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): In a HA cluster, each kube-apiserver has an ID. Controllers have access to the list of IDs for living kube-apiservers in the cluster.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1965-kube-apiserver-identity
  • Primary contact (assignee): @roycaihw
  • Responsible SIGs: sig-api-machinery
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) 1.20
    • Beta release target (x.y) TBD
    • Stable release target (x.y) TBD

Related PRs:

  • Move lease controller: https://github.com/kubernetes/kubernetes/pull/95428
  • kube-apiserver lease controller: https://github.com/kubernetes/kubernetes/pull/95533
  • apiserver lease garbage collector: https://github.com/kubernetes/kubernetes/pull/95895
  • documentation: https://github.com/kubernetes/website/pull/24921
  • metrics: https://github.com/kubernetes/enhancements/pull/3005

roycaihw avatar Sep 02 '20 18:09 roycaihw

/sig api-machinery

roycaihw avatar Sep 03 '20 07:09 roycaihw

Hi @roycaihw

Enhancements Lead here. Can you confirm that this is intended for alpha in 1.20?

Thanks Kirsten

kikisdeliveryservice avatar Sep 13 '20 23:09 kikisdeliveryservice

@kikisdeliveryservice Yes. This feature is intended for alpha in 1.20.

@lavalamp @deads2k Could one of you add this issue to the release 1.20 milestone?

roycaihw avatar Sep 14 '20 21:09 roycaihw

thanks for the update

/milestone v1.20

kikisdeliveryservice avatar Sep 14 '20 21:09 kikisdeliveryservice

Some KEP updates here: https://github.com/kubernetes/enhancements/pull/1998 https://github.com/kubernetes/enhancements/pull/1999

But as a reminder, to be included in a release, by Enhancements Freeze (October 6th) all KEPs:

The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria.

Also updated description to link directly to merged KEP.

kikisdeliveryservice avatar Sep 22 '20 18:09 kikisdeliveryservice

@kikisdeliveryservice Thanks for the reminder! Will do.

roycaihw avatar Sep 22 '20 19:09 roycaihw

Hi @roycaihw ,

Enhancement shadow for 1.20 release here 👋 . As we're moving closer to the Enhancement Freeze deadline (October 6), just wanted to remind you to update your KEP PR,

We're looking for the KEP PR to have the following before this deadline:

  • should have test plans
  • should have graduation criteria
  • should be merged in implementable state

Thank you!

kinarashah avatar Sep 29 '20 17:09 kinarashah

@kinarashah Thanks for the reminder. The KEP is now implementable https://github.com/kubernetes/enhancements/pull/1998, and has test plans and graduation criteria.

roycaihw avatar Sep 30 '20 00:09 roycaihw

Hi @roycaihw ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

kinarashah avatar Oct 11 '20 19:10 kinarashah

Hello @roycaihw , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

reylejano avatar Oct 19 '20 15:10 reylejano

Hi @roycaihw

The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

reylejano avatar Nov 01 '20 17:11 reylejano

Hi @reylejano-rxm, I've created the docs placeholder https://github.com/kubernetes/website/pull/24921 and updated the description with links to related PRs. Thanks!

roycaihw avatar Nov 06 '20 05:11 roycaihw

Hi @roycaihw

I see that kubernetes/kubernetes#91389 has not yet merged.

Just a reminder that Code Freeze is tomorrow Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks, Kirsten

kikisdeliveryservice avatar Nov 11 '20 18:11 kikisdeliveryservice

Thanks @kikisdeliveryservice. I think kubernetes/kubernetes#91389 is tracked in the Priority and Fairness feature: https://github.com/kubernetes/enhancements/issues/1040#issuecomment-724814313.

The alpha-level functionality for kube-apiserver identity has been implemented. All PRs linked in the description have been merged, except the doc one.

roycaihw avatar Nov 12 '20 01:11 roycaihw

Great!! Thanks for clarifying - congrats!

kikisdeliveryservice avatar Nov 12 '20 06:11 kikisdeliveryservice

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jun 01 '21 02:06 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot avatar Jul 01 '21 03:07 fejta-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-triage-robot avatar Jul 31 '21 04:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 31 '21 04:07 k8s-ci-robot

/reopen

Haowei, what should happen next on this?

lavalamp avatar Aug 02 '21 22:08 lavalamp

@lavalamp: Reopened this issue.

In response to this:

/reopen

Haowei, what should happen next on this?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 02 '21 22:08 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Sep 01 '21 23:09 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 01 '21 23:09 k8s-ci-robot

/reopen /lifecyle frozen

lavalamp avatar Sep 01 '21 23:09 lavalamp

@lavalamp: Reopened this issue.

In response to this:

/reopen /lifecyle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 01 '21 23:09 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Oct 02 '21 00:10 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 02 '21 00:10 k8s-ci-robot

/reopen /remove-lifecycle rotten

roycaihw avatar Nov 12 '21 01:11 roycaihw

@roycaihw: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 12 '21 01:11 k8s-ci-robot

Metric improvements in progress: https://github.com/kubernetes/enhancements/pull/3005

roycaihw avatar Nov 12 '21 01:11 roycaihw