enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Auto remove PVCs created by StatefulSet

Open kk-src opened this issue 5 years ago • 120 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Auto remove PVCs created by StatefulSet

  • Kubernetes Enhancement Proposal: KEP-1847: Auto remove PVCs created by StatefulSet.

  • Primary contact (assignee): @mattcary

  • Responsible SIGs: @sig-apps (with collaboration by @sig-storage)

  • Enhancement target (which target equals to which milestone):

    • Alpha release target 1.23
    • Beta release target 1.27
    • Stable release target 1.32
  • [x] Beta
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3800
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/116501
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/39926
      • https://github.com/kubernetes/website/pull/39819
  • [ ] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4901
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update(s):

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Resolves kubernetes/kubernetes#55045

kk-src avatar Jun 06 '20 05:06 kk-src

@kk-src: The label(s) sig/sig-storage cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 06 '20 05:06 k8s-ci-robot

/sig storage

kk-src avatar Jun 06 '20 05:06 kk-src

/assign

kk-src avatar Jun 06 '20 06:06 kk-src

@kubernetes/sig-storage-feature-requests

pacoxu avatar Jun 19 '20 07:06 pacoxu

@pacoxu: Reiterating the mentions to trigger a notification: @kubernetes/sig-storage-feature-requests

In response to this:

@kubernetes/sig-storage-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 19 '20 07:06 k8s-ci-robot

CC @dsu-igeek

xing-yang avatar Jun 19 '20 14:06 xing-yang

Having discussions with @dsu-igeek @msau42 @mattcary Should have a KEP with the proposal in shortly.

kk-src avatar Jun 19 '20 18:06 kk-src

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Sep 17 '20 18:09 fejta-bot

Hi @kk-src

Enhancements Lead here. Will there be any work for this in 1.20?

Also, as a reminder to be included in a release:

The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria.

Thanks Kirsten

kikisdeliveryservice avatar Sep 21 '20 22:09 kikisdeliveryservice

As per https://github.com/kubernetes/enhancements/pull/1915#issuecomment-698445762

marking this is as tracked.

Please note that Enhancements Freeze is October 6th, by which time to be included in the milestone: The KEP must be merged in an implementable state (not yet merged & provisional) The KEP must have test plans (missing) The KEP must have graduation criteria (missing)

Best, Kirsten

kikisdeliveryservice avatar Sep 24 '20 16:09 kikisdeliveryservice

/milestone v1.20

kikisdeliveryservice avatar Sep 24 '20 16:09 kikisdeliveryservice

Hi @kk-src :wave:!

I'm one of the Enhancement shadows for the 1.20 release cycle. This is a friendly reminder that the Enhancement freeze is roughly one week from now on the 6th of October. I'm repeating the requirements needed by then:

  • The KEP must be merged in an implementable state.
    • It's provisional at the moment.
  • The KEP must have test plans.
    • Missing in the KEP.
  • The KEP must have graduation criteria.
    • Also missing in the KEP.

Let us know if you have any questions etc.!

Thanks!

mikejoh avatar Sep 29 '20 18:09 mikejoh

As a reminder, the Enhancements Freeze is Tomorrow October 6th EOD PST. All KEPs and updates must be merged by that time. After October 6th, you will need to request an Exception to be included in the 1.20 Release.

mikejoh avatar Oct 05 '20 18:10 mikejoh

Hi @kk-src

Enhancements Freeze is now in effect. Unfortunately, your KEP PR has not merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best, Kirsten 1.20 Enhancements Lead

kikisdeliveryservice avatar Oct 07 '20 02:10 kikisdeliveryservice

/remove-lifecycle stale

kk-src avatar Oct 09 '20 17:10 kk-src

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 07 '21 18:01 fejta-bot

Hi @mattcary

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR https://github.com/kubernetes/enhancements/pull/2440). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

annajung avatar Feb 07 '21 18:02 annajung

With PR https://github.com/kubernetes/enhancements/pull/2440 merged, this enhancement has met all the requirements for the enhancements freeze 👍

annajung avatar Feb 09 '21 14:02 annajung

Greetings @mattcary @kk-src, Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates: • Tuesday, March 9th: Week 9 - Code Freeze • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo. As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them. Thanks!

jrsapi avatar Feb 18 '21 19:02 jrsapi

Docs placeholder PR: https://github.com/kubernetes/website/pull/26683

mattcary avatar Feb 23 '21 17:02 mattcary

Greetings @mattcary @kk-src,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back. Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST. Thanks!

jrsapi avatar Mar 04 '21 20:03 jrsapi

Hi @mattcary, with code freeze now in effect, we are removing this enhancement from 1.21 release due to https://github.com/kubernetes/kubernetes/pull/99378 and https://github.com/kubernetes/kubernetes/pull/99728 not being merged or approved.

Feel free to file an exception to add this back into the release. thanks!

annajung avatar Mar 10 '21 03:03 annajung

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot avatar Apr 09 '21 04:04 fejta-bot

/lifecycle frozen

mattcary avatar Apr 12 '21 16:04 mattcary

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

fejta-bot avatar Apr 12 '21 16:04 fejta-bot

This implementation is under active development and should be able to go in after the 1.21 freeze is done.

mattcary avatar Apr 12 '21 17:04 mattcary

/milestone v1.22

JamesLaverack avatar Apr 28 '21 01:04 JamesLaverack

Hi @mattcary,

1.22 release team here. After reviewing the kep and approved PRR there's a few things that needs to be done before the 1.22 Enhancements Freeze which starts at 23:59:59 pst on Thursday, May 13:

  • In the kep README.md, update the TODO under the Test Plan
  • In the kep.yaml, update the values of latest-milestone and alpha milestone to "v1.22". Update the beta and stable milestones accordingly

reylejano avatar May 11 '21 03:05 reylejano

/sig apps

reylejano avatar May 11 '21 03:05 reylejano

Thanks @reylejano!. PR created: https://github.com/kubernetes/enhancements/pull/2715

mattcary avatar May 11 '21 18:05 mattcary