dashboard
dashboard copied to clipboard
kubernetes
fix: workload charts are black for certain languages
For certain languages such as KR and FR, the workload charts are black.
The current code is pulling out the translation for the different statuses by passing Running, Succeeded, etc; just that there are different texts (3) starting with Running, Succeeded, etc.
The code change passes in an empty string for placeholder to mimic how status label names were generated; thus the translated text will be a substring of the status label names.
https://github.com/kubernetes/dashboard/blob/5d6805dca8ab1b8ec93b335f78b8431959f7586b/modules/web/src/overview/helper.ts#L30-L34
closes https://github.com/kubernetes/dashboard/issues/8898 closes https://github.com/kubernetes/dashboard/issues/8753
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: HanNguyen-dev / name: Han Nguyen (02dd071d616f1ced330a45784ab5a00d9902e893, fc0fa516a7d79a3ca6c42a744e727e5351f5ec57, 49342503f466ac1e253a203ff19af5db0bc3f950)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @HanNguyen-dev!
It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/dashboard has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
I agree , it is a nice fix. It will Help to fix the issue in all languages at once. /lgtm
@gdelvallez1: changing LGTM is restricted to collaborators
In response to this:
I agree , it is a nice fix. It will Help to fix the issue in all languages at once. /lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Nice fix, @HanNguyen-dev ! Do you know why it is not going through? Does it maybe need the review from @maciaszczykm or @shu-mutou ?
Hi @vittoriocanilli, I forgot that this PR is still here. I am not familiar with PR process to be honest, but I'll go through their documentation to see what is missing.
I'll pull the latest from master as well, and add some steps to reproduce this bug locally.
/assign @maciaszczykm /assign @shu-mutou
Can you review this PR? Thanks
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: floreks, gdelvallez1, HanNguyen-dev
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [floreks]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks @floreks.
I was suppose to close this PR a few weeks ago since there were some auto-generated translation files that I wasn't sure to include in this PR or not.
But thank you.