kubernetes
Add external traffic policy to chart service
Minor update to add externalTrafficPolicy to the dashboard service. Let me now if there is anything else needed or suggested for this change.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: Keydrain / name: Clint (10d264955c8bcf873c7fca33c54b5151383c632a, 5cc74b4fbbf42b64f47dae08ff7122dfe47f346a)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @Keydrain!
It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/dashboard has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
@Keydrain can you sign the CLA so we will take a look?
@desaintmartin Can you take a look?
@Keydrain: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Keydrain, maciaszczykm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [maciaszczykm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks! Could you bump minor version in Chart.yaml? According to semver, this is new feature.
^
Codecov Report
Merging #7282 (22cfe60) into master (6b46644) will increase coverage by
0.02%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #7282 +/- ##
==========================================
+ Coverage 42.08% 42.10% +0.02%
==========================================
Files 217 217
Lines 12084 12084
Branches 179 179
==========================================
+ Hits 5085 5088 +3
+ Misses 6715 6711 -4
- Partials 284 285 +1
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Keydrain, maciaszczykm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~charts/helm-chart/kubernetes-dashboard/OWNERS~~ [maciaszczykm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Keydrain: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Closing as inactive. @Keydrain feel free to reopen if you want to move forward with this.