Update ingress.yaml to accomodate kong service ports

[mrjoshuap]

This template built an ingress that incorrectly set $servicePort based on app.ingress.tls.enabled.

This fixes that by using the kong.proxy.tls.enabled for the check instead, thereby selecting the correct service port.

It also adjusts the default annotations to check for app.ingress.tls.enabled so unnecessary annotations are avoided.

Finally, it properly sets the backend protocol based on kong.proxy.tls.enabled.

I see a few different scenarios:

• SSL Passthrough

  • app.ingress.tls.enabled == false
  • kong.proxy.tls.enabled == true

• Ingress terminated TLS

  • app.ingress.tls.enabled == true
  • kong.proxy.tls.enabled == false

• Ingress TLS to Kong TLS, though not sure this works because the default ingress annotation nginx.ingress.kubernetes.io/ssl-redirect: "true"

  • app.ingress.tls.enabled == true
  • kong.proxy.tls.enabled == true

I don't think HTTP to HTTPS proxying is a good idea, so I won't talk more about it.

To fix TLS to TLS, there might be a need to add an additional parameter enabling ssl-passthrough behavior. In this implementation, if kong.proxy.tls.enabled=true then it assumes you want to perform SSL-passthrough. I haven't verified as I'm using Ingress terminated TLS and can't test the needful.

I suspect this has been the culprit of many threads regarding Error 400 HTTP request to HTTPS, though I think that might also have something to do with http2 requirements on the proxy -- at least on my deployment.

[linux-foundation-easycla[bot]]

• :white_check_mark:login: mrjoshuap / (fca4726ea53e4045412dc18a455e7921d0713a37)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrjoshuap Once this PR has been reviewed and has the lgtm label, please assign desaintmartin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/kubernetes-dashboard/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @mrjoshuap!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[mrjoshuap]

This sort of extends the fix applied in #9863

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.