component-base icon indicating copy to clipboard operation
component-base copied to clipboard

Upgrade opentelemetry to new version

Open pugangxa opened this issue 3 years ago • 11 comments

There's breaking changes in opentelemetry new version, see https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md

That is to say a project does not work if it depend on this repo and there's also direct/indirect dependencies on the new version of opentelemetry

pugangxa avatar Mar 31 '22 06:03 pugangxa

+1 - for now Gatekeeper has gotten lucky since Open Policy Agent and Kubernetes, while they use incompatible versions of opentelemetry, use different enough packages within the library that we've still been able to upgrade our OPA dependency.

willbeason avatar Apr 05 '22 14:04 willbeason

This can't happen until etcd upgrades their opentelemetry transitive dependency:

https://github.com/etcd-io/etcd/pull/13888

willbeason avatar Apr 05 '22 16:04 willbeason

@willbeason I saw the etcd issue approved, seems can proceed to merge, Thanks.

pugangxa avatar Apr 13 '22 02:04 pugangxa

You're welcome! I think they'll need to merge once they run tests on my typo fix.

willbeason avatar Apr 13 '22 13:04 willbeason

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 12 '22 13:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 11 '22 14:08 k8s-triage-robot

/remove-lifecycle rotten

pradeepvrd avatar Aug 31 '22 16:08 pradeepvrd

@willbeason Looks like etcd has upgraded their transitive dependency. Would it be possible to look at this issue again?

pradeepvrd avatar Aug 31 '22 16:08 pradeepvrd

@willbeason Looks like etcd has upgraded their transitive dependency. Would it be possible to look at this issue again?

I've started grad school so I don't have my old work development environment anymore. I'll see if I can pull a PR together tomorrow, but if it looks like it'll be too much work I'll need to hand it off.

willbeason avatar Sep 01 '22 14:09 willbeason

This issue has been fixed by https://github.com/kubernetes/kubernetes/pull/112545 and the files have been synced here by https://github.com/kubernetes/component-base/commit/1b02e586f291000c4230d7e81c21b708266abbdc.

So when will a new tag be created to finally solve this problem?

ityuhui avatar Sep 20 '22 05:09 ityuhui

Finally made it on the apiserver library side in https://github.com/kubernetes/apiserver/commit/63a5dc29683163dd50e6c509363d9b0385ed0975 too, so hopefully soon enough...

Tristan971 avatar Sep 20 '22 14:09 Tristan971

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 19 '22 14:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 18 '23 15:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Feb 17 '23 16:02 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 17 '23 16:02 k8s-ci-robot