community icon indicating copy to clipboard operation
community copied to clipboard

API conventions: add more on defaulting

Open thockin opened this issue 3 years ago • 7 comments

In reviewing an issue/PR I realized this lesson had not been documented anywhere. This is not the ideal mechanism, IMO, but better than nothing.

This comes out of Service ClusterIP and NodePorts, plus #103546

@robscott @aojea @khenidak @liggitt @msau42

thockin avatar Jul 28 '22 23:07 thockin

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 28 '22 23:07 k8s-ci-robot

Also @apelisse - it might be interesting to denote some fields as +patchOnUnset or something?

thockin avatar Jul 28 '22 23:07 thockin

Oh, this needs a TOC update - didn't we have a tool for that?

Edit: done

thockin avatar Jul 28 '22 23:07 thockin

All comments addressed in the text, I hope. Compare: https://github.com/kubernetes/community/compare/86597c5414674efde1ef8d3ab8de2b3306d87990..7cbe84067ec732f27e2d73d9fa3facc649354757

thockin avatar Jul 29 '22 19:07 thockin

Looks great to me, thanks

apelisse avatar Aug 05 '22 16:08 apelisse

LGTM

defer to @liggitt

aojea avatar Aug 08 '22 07:08 aojea

Small updates made and pushed: https://github.com/kubernetes/community/compare/7cbe84067ec732f27e2d73d9fa3facc649354757..c307bcaa46e51b3b51a944237185932a47d6af23

thockin avatar Aug 12 '22 20:08 thockin

/lgtm /hold in case you wanted other eyes, unhold at will

liggitt avatar Aug 16 '22 20:08 liggitt

/unhold

thockin avatar Aug 16 '22 22:08 thockin