community icon indicating copy to clipboard operation
community copied to clipboard

Update channels.yaml to add ACK

Open mikestef9 opened this issue 3 years ago • 7 comments
trafficstars

Proposal for new channel dedicated to discussion of AWS Controllers for Kubernetes

https://aws-controllers-k8s.github.io/community/

mikestef9 avatar Jul 28 '22 19:07 mikestef9

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mikestef9 / name: Mike Stefaniak (9892f2d9c4a61fe7db26107ef9aec476a6d6909f)

Welcome @mikestef9!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 28 '22 19:07 k8s-ci-robot

Hi @mikestef9. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 28 '22 19:07 k8s-ci-robot

@mikestef9 Please tag me once that is done and I will start the first part of the review. Thanks kindly.

markjacksonfishing avatar Jul 28 '22 19:07 markjacksonfishing

@markyjackson-taulia Just signed the CLA

mikestef9 avatar Jul 28 '22 19:07 mikestef9

/ok-to-test

markjacksonfishing avatar Jul 28 '22 19:07 markjacksonfishing

/assign @alejandrox1

mikestef9 avatar Aug 16 '22 15:08 mikestef9

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markyjackson-taulia, mikestef9, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 16 '22 15:08 k8s-ci-robot

woops, thought I released the hold - will do that now /hold cancel

mrbobbytables avatar Aug 29 '22 14:08 mrbobbytables