community icon indicating copy to clipboard operation
community copied to clipboard

Add multi-network channel.

Open mskrocki opened this issue 3 years ago • 11 comments

This PR adds multi-network channel where community will discuss on introducing multi network concept and a Network construct into Kubernetes.

Fixes #6751

mskrocki avatar Jul 19 '22 23:07 mskrocki

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mskrocki / name: Maciej Skrocki (bc114c33feb154e0528a0ce7cf3693df9d960bd7)

Welcome @mskrocki!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 19 '22 23:07 k8s-ci-robot

Hi @mskrocki. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 19 '22 23:07 k8s-ci-robot

Is this something run by a SIG? If so can it be under that SIG namespace?

coderanger avatar Jul 20 '22 00:07 coderanger

It is network related so I think it would fall under the network SIG, and yeah it could be under that namespace. /Cc @dcbw @thockin @aojea

mskrocki avatar Jul 20 '22 17:07 mskrocki

/ok-to-test LGTM

@thockin for the naming, he loves that :smile:

aojea avatar Jul 20 '22 17:07 aojea

Cc @coderanger

markjacksonfishing avatar Jul 28 '22 13:07 markjacksonfishing

"under the SIG namespace" means make the channel name something like #sig-networking-multinetwork or similar, so it's clearly associated with the SIG.

coderanger avatar Jul 30 '22 06:07 coderanger

@dcbw ping. can you take a quick look there?

jellonek avatar Aug 04 '22 18:08 jellonek

Channel has been renamed properly.

/lgtm /approve

@dcbw @thockin @aojea if you have no objections, I'll remove the hold in a day or so.

jberkus avatar Aug 23 '22 00:08 jberkus

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, markyjackson-taulia, mskrocki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 23 '22 00:08 k8s-ci-robot

Once that is reviewed and the approved label added, the hold will be canceled and this will merge automagically.

/lgtm

Thanks Josh,

aojea avatar Aug 23 '22 04:08 aojea

/remove-hold

jberkus avatar Aug 23 '22 15:08 jberkus