cloud-provider-aws icon indicating copy to clipboard operation
cloud-provider-aws copied to clipboard

Add request handlers to v2 implementation

Open randomvariable opened this issue 5 years ago • 8 comments

What would you like to be added: Follow up from #131, add AWS request handlers to do the following:

  • Add metrics
  • Add rate limiting

@M00nF1sh , do you think it's worth re-implementing what's done in in https://github.com/aws/aws-app-mesh-controller-for-k8s/tree/master/pkg/aws for the above?

FWIW, I used the same metric formats in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/metrics/metrics.go, so would be worth standardising.

Why is this needed:

/kind feature

randomvariable avatar Sep 30 '20 10:09 randomvariable

@randomvariable Thanks for reaching out. I think we can keep same format(i'm open to new metrics if applicable) :D

M00nF1sh avatar Sep 30 '20 19:09 M00nF1sh

@M00nF1sh Are we ok to copy the throttle package over to this repo and cluster-api?

randomvariable avatar Oct 01 '20 09:10 randomvariable

@randomvariable of course. but i do think the throttle package needs some enhancements. e.g. it should use endpointID instead of serviceName when throttling. since some service's serviceName have space within it.

M00nF1sh avatar Oct 01 '20 17:10 M00nF1sh

/assign

randomvariable avatar Oct 01 '20 18:10 randomvariable

I spoke with @jaypipes and he is going to create a repository under the aws organization to put the throttle package and any other widely shared utils. @M00nF1sh WDYT about that?

nckturner avatar Oct 08 '20 02:10 nckturner

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Jan 06 '21 03:01 fejta-bot

@jaypipes has any progress been made on creating the repo to include importable limiters?

randomvariable avatar Jan 12 '21 13:01 randomvariable

/lifecycle frozen

randomvariable avatar Jan 12 '21 13:01 randomvariable