autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Bump the go version to v1.23.2 for the GitHub workflows.

Open Shubham82 opened this issue 10 months ago • 12 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump the go version under GitHub workflow to 1.23.2, as Dockerfile and go.mod uses go version 1.23.2

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Shubham82 avatar Jan 20 '25 10:01 Shubham82

Hi @gjtempleton @MaciekPytel PTAL!

Shubham82 avatar Jan 20 '25 11:01 Shubham82

Question for a future improvement: Worth scripting something up to keep these versions in sync whenever we touch one of them? (Potentially an extension to the existing update-deps.sh?)

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

gjtempleton avatar Jan 20 '25 14:01 gjtempleton

Question for a future improvement: Worth scripting something up to keep these versions in sync whenever we touch one of them? (Potentially an extension to the existing update-deps.sh?)

@gjtempleton, That sounds good. We can script this part so that the go version under ci.yaml will also be updated when we update other dependencies.

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

IMO, there is no risk, as projects used the go version corresponding to the latest k8s version.

VPA: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/go.mod

@gjtempleton your thoughts?

Shubham82 avatar Jan 20 '25 15:01 Shubham82

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

IMO, there is no risk, as projects used the go version corresponding to the latest k8s version.

Is this a requirement? Is there value in the projects in this repo matching the k/k go version?

adrianmoisey avatar Jan 23 '25 05:01 adrianmoisey

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

IMO, there is no risk, as projects used the go version corresponding to the latest k8s version.

Is this a requirement? Is there value in the projects in this repo matching the k/k go version?

Talking about CA, For every CA release, we update the corresponding upstream dependencies(k8s), so CA version and Kubernetes version have a one-to-one correspondence. I think it is with VPA also, There was some talk of improvement in this area in vpa (#5759)

Shubham82 avatar Jan 23 '25 11:01 Shubham82

Talking about CA, For every CA release, we update the corresponding upstream dependencies(k8s), so CA version and Kubernetes version have a one-to-one correspondence.

What is the reason for this? Is there a need to have a one-to-one correspondence?

adrianmoisey avatar Jan 23 '25 12:01 adrianmoisey

Hi @adrianmoisey CA imports a huge chunk of internal k8s code because it calls out to the scheduler implementation. Therefore, to avoid version incompatibilities we keep the set of libraries used in CA as used by k8s.

Shubham82 avatar Jan 27 '25 11:01 Shubham82

cc @gjtempleton, Can we merge this PR? Later we can add the script for it that you suggested above.

Shubham82 avatar Feb 04 '25 17:02 Shubham82

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jackfrancis, Shubham82 Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 03 '25 16:03 k8s-ci-robot

hi @gjtempleton, Could you approve this PR?

Shubham82 avatar Mar 10 '25 06:03 Shubham82

hi @gjtempleton, Could you approve this PR?

Shubham82 avatar Mar 10 '25 06:03 Shubham82

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 03 '25 07:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 01 '25 08:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 01 '25 09:10 k8s-triage-robot

these files have been synchronized to 1.24.0, see:

  • https://github.com/kubernetes/autoscaler/pull/8192
  • https://github.com/kubernetes/autoscaler/pull/8121

jackfrancis avatar Oct 01 '25 15:10 jackfrancis