autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Convert resources to a more human relevant SI

Open jacobeatsspam opened this issue 1 year ago • 3 comments

Which component are you using?:

VPA

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Yes. VPA memory recommendations are applied as kilobytes (k, the non-binary 1000 byte) and it's not very relevant to the humans that are reading the podspec later.

Describe the solution you'd like.:

Convert to the units to highest SI suffix without decimal places.

Describe any alternative solutions you've considered.:

N/A

jacobeatsspam avatar Oct 21 '24 17:10 jacobeatsspam

/area vertical-pod-autoscaler

This looks like a dupe of https://github.com/kubernetes/autoscaler/issues/7094

adrianmoisey avatar Oct 21 '24 19:10 adrianmoisey

I’m happy to help with that if needed.

omerap12 avatar Oct 22 '24 09:10 omerap12

Go for it! /assign omerap12

adrianmoisey avatar Oct 22 '24 11:10 adrianmoisey

Hi all, I tried with 1.3.0 image with "--humanize-memory=true" today, but found the MEM value now having more digits with the unit "milibyte". This value looks to align with the code design 272063528960/1000/1024/1024=259.46Mi, but seems more unreadable. Is there some configuration I missed?

$ k get verticalpodautoscalers.autoscaling.k8s.io -n logging fluent-bit-service
NAME                 MODE      CPU    MEM             PROVIDED   AGE
fluent-bit-service   Initial   126m   272063528960m   True       2d21h

kyleli666 avatar Jan 26 '25 03:01 kyleli666