autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

azure CAS: add reviewers

Open jackfrancis opened this issue 1 year ago • 12 comments

What type of PR is this?

What this PR does / why we need it:

This PR adds reviewers to the Azure CAS provider based on demonstrated participation in the project. See:

  • https://github.com/kubernetes/autoscaler/pulls?q=is%3Aclosed+is%3Apr+label%3Aarea%2Fprovider%2Fazure+

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

jackfrancis avatar Sep 19 '24 17:09 jackfrancis

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • charliedmcb
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • aagusuab
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • rakechill
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

k8s-ci-robot avatar Sep 19 '24 17:09 k8s-ci-robot

Thank you @nojnhuh @rakechill @charliedmcb @aagusuab !!!

jackfrancis avatar Sep 19 '24 17:09 jackfrancis

/assign @tallaxes

jackfrancis avatar Sep 19 '24 17:09 jackfrancis

ping @tallaxes

jackfrancis avatar Oct 16 '24 15:10 jackfrancis

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 14 '25 15:01 k8s-triage-robot

/remove-lifecycle stale

jackfrancis avatar Jan 14 '25 16:01 jackfrancis

/lgtm /approve

tallaxes avatar Jan 14 '25 17:01 tallaxes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, tallaxes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 14 '25 17:01 k8s-ci-robot

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • charliedmcb

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

  • aagusuab

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

  • rakechill

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Hi, @jackfrancis this PR is not merged because the members you added for reviewers are not the members in the k8s org, It will be good if they can become members in k8s org so they can review and give lgtm to the PR easily otherwise lgtm label will not work for them.

Shubham82 avatar Jan 21 '25 09:01 Shubham82

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • charliedmcb

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

  • aagusuab

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

  • rakechill

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Hi, @jackfrancis this PR is not merged because the members you added for reviewers are not the members in the k8s org, It will be good if they can become members in k8s org so they can review and give lgtm to the PR easily otherwise lgtm label will not work for them.

Hi @jackfrancis, any update on this?

Shubham82 avatar Mar 04 '25 09:03 Shubham82

/hold unhold it, once members (in the owners file) become members in k8s org.

Shubham82 avatar Mar 04 '25 09:03 Shubham82

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 02 '25 10:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jul 02 '25 10:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Aug 01 '25 10:08 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 01 '25 10:08 k8s-ci-robot