kubernetes
Fixed verbiage of the method calculateCoresMemoryTotal
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Clarifies what is the intention of the method, which is to simply calculate the total amount of resources for CPU/Memory from the cluster nodes.
Which issue(s) this PR fixes:
Fixes the misleading interpretation that it is being checked resource usage based on metrics.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: ehvs / name: Hevellyn (e2595d67b9a4549c2e3c9584740410289066bf54, 1c528f6f5157d4c2919614d7e1bf4706da58c0b3)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @ehvs!
It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/autoscaler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @ehvs. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
cc @x13n @BigDarkClown Need your approval to merge this PR, PTAL!
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ehvs, x13n
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cluster-autoscaler/OWNERS~~ [x13n]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment