autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Add script to update cluster-autoscaler flags doc

Open rainfd opened this issue 1 year ago • 9 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fxies #6981

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


rainfd avatar Jul 09 '24 07:07 rainfd

Welcome @rainfd!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 09 '24 07:07 k8s-ci-robot

Hi @rainfd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 09 '24 07:07 k8s-ci-robot

/ok-to-test

Shubham82 avatar Jul 09 '24 07:07 Shubham82

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 07 '24 07:10 k8s-triage-robot

/remove-lifecycle stale

Shubham82 avatar Oct 07 '24 08:10 Shubham82

I have one concern not all the flags are in the parameter table(Flags table in FAQ) you mentioned in this PR. I also checked the script locally, it generated the table but not all the flags are there which are mentioned in the CA main.go. One of the flags is nodeDeletionDelayTimeout.

Please let me know if I missed something here.

Shubham82 avatar Oct 16 '24 17:10 Shubham82

@Shubham82 Alias node-deletion-delay-timeout is in the definition

nodeDeletionDelayTimeout    = flag.Duration("node-deletion-delay-timeout", 2*time.Minute, "Maximum time CA waits for removing delay-deletion.cluster-autoscaler.kubernetes.io/ annotations before deleting the node.")

rainfd avatar Oct 17 '24 09:10 rainfd

@Shubham82 Alias node-deletion-delay-timeout is in the definition

nodeDeletionDelayTimeout    = flag.Duration("node-deletion-delay-timeout", 2*time.Minute, "Maximum time CA waits for removing delay-deletion.cluster-autoscaler.kubernetes.io/ annotations before deleting the node.")

Sorry My bad, I forgot to mention the hyphen(-) in the flag name, I have rechecked it locally, and flags are generated from the script.

Thanks!

Shubham82 avatar Oct 17 '24 10:10 Shubham82

/remove-area vertical-pod-autoscaler

voelzmo avatar Oct 25 '24 08:10 voelzmo

/remove-area provider/gce /remove-area provider/azure

Shubham82 avatar Oct 25 '24 08:10 Shubham82

Is there any ETA for this PR to be merged?

pierluigilenoci avatar Nov 07 '24 09:11 pierluigilenoci

Thanks @rainfd for this PR. /lgtm

Shubham82 avatar Jan 06 '25 10:01 Shubham82

Thanks for this, a real improvement! /approve

gjtempleton avatar Jan 06 '25 10:01 gjtempleton

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, rainfd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 06 '25 10:01 k8s-ci-robot