autoscaler
autoscaler copied to clipboard
kubernetes
fix(helm): add clusterIP to values.yaml
What type of PR is this?
/kind bug
What this PR does / why we need it:
Supports service.clusterIP template for autoscaler chart.
Which issue(s) this PR fixes:
Fixes #6631
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: eshiettjoseph / name: Joseph Eshiett (af664a29c5f857da5b6d588aa85e693933125e19, b8ca18d6f42bf96d1f01c15de31bb32ed34d5b82, 31ff8fadf161be4e8ffb4c991b6bb36cfd6a9b12, 21e0c0bee896a3a15896df6e6273268ce8536fdf)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @eshiettjoseph!
It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/autoscaler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @eshiettjoseph. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: eshiettjoseph Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @eshiettjoseph
Please address the failed Test Cases i.e. Lint and Test Charts / Helm chart (pull_request) and Lint and Test Charts / Helm Docs (pull_request), that are required to be passed.
JFYI: you have to install Pre-commit hooks before working in the Charts.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@eshiettjoseph, is there any update on this issue, to merge this PR you have to resolve the merge conflicts.
See this comment here: https://github.com/kubernetes/autoscaler/issues/6631#issuecomment-2380159234
The main thing we want to do here is to add clusterIP to the values.yaml file, and to run helm-docs command line tool to regenerate documentation.
If there are links in the comments that need to be updated for other properties that should be a discrete PR. Happy to review that quickly, if so.
IMO the changes here shouldn't need a helm chart version bump, but we'll see what the linter says. :)
@jackfrancis: The label(s) /label kind-bug cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label kind-bug
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jackfrancis: The label(s) /label kind/bug cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label kind/bug
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
If there are links in the comments that need to be updated for other properties that should be a discrete PR. Happy to review that quickly, if so.
Hi @jackfrancis, we also have to update the link, it will be good if we can do it in this PR only but I'm also OK with another PR for it.
@eshiettjoseph @Shubham82 this PR is next in the queue for merging, so if you rebase on top of master and rev the chart version again it should be the last time you have to do that!
@eshiettjoseph, are you working on this PR, if Yes then could you please resolve the merge conflicts so that it will be merged?
Thanks!
Hi @jackfrancis, no response from @eshiettjoseph till now, should we open a new PR for it and close this one, or should we wait more? I just want issue #6631 to be closed, as it has been open for a long time.
cc @gjtempleton @jackfrancis
If you are ok, then I will open a new PR for it.
@Shubham82 I'll happily lgtm an equivalent version of this change in a new PR!
@Shubham82 I'll happily lgtm an equivalent version of this change in a new PR!
Thanks @jackfrancis for the confirmation, I will open a new PR for this fix.
closing this PR, as PR https://github.com/kubernetes/autoscaler/pull/7452 is merged now.