autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

feat(chart): Add support for civo provider

Open rbnis opened this issue 1 year ago • 11 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for the Civo Cloud provider to the helm chart.

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

Support for civo provider added to helm chart

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


rbnis avatar Mar 25 '24 22:03 rbnis

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: rbnis / name: Robin (c24634507b44e84a972f6edd202ca14cc9a7a265)

Welcome @rbnis!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 25 '24 22:03 k8s-ci-robot

Hi @rbnis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 25 '24 22:03 k8s-ci-robot

/ok-to-test

Shubham82 avatar Apr 02 '24 09:04 Shubham82

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 01 '24 09:07 k8s-triage-robot

/remove-lifecycle stale

Shubham82 avatar Jul 01 '24 10:07 Shubham82

@rbnis, please resolve the merge conflict.

Shubham82 avatar Sep 24 '24 07:09 Shubham82

Sorry, for accidentally closing this PR. I just rebased it and responded to the open comment

rbnis avatar Oct 13 '24 09:10 rbnis

Hi @jackfrancis, I think this PR is next in the queue for merging, (I checked the dashboard you created for Helm chart PR) If it is then we can rebase this PR on top of the master and revise the chart version.

IMO, we consider this PR, as it has been open for a long time.

Shubham82 avatar Nov 04 '24 18:11 Shubham82

@rbnis, could you please resolve the merge conflict and the failed test case?

Shubham82 avatar Nov 04 '24 18:11 Shubham82

@Shubham82 @jackfrancis I just rebased this PR and fixed the Helm Docs test case.

rbnis avatar Nov 04 '24 19:11 rbnis

Thanks @rbnis /lgtm

Shubham82 avatar Nov 05 '24 12:11 Shubham82

cc @jackfrancis @gjtempleton need your approval to merge this PR.

Shubham82 avatar Nov 05 '24 12:11 Shubham82

New changes are detected. LGTM label has been removed.

Latest push is just a rebase again.

rbnis avatar Jan 06 '25 21:01 rbnis

/lgtm

Shubham82 avatar Jan 07 '25 09:01 Shubham82

cc @gjtempleton @jackfrancis could you please approve this PR?

Thanks!

Shubham82 avatar Jan 07 '25 09:01 Shubham82

/lgtm

/assign @gjtempleton

jackfrancis avatar Jan 10 '25 17:01 jackfrancis

cc @gjtempleton could you please approve this PR, so that it will merge

Thanks!

Shubham82 avatar Jan 20 '25 15:01 Shubham82

@rbnis could you please revise the chart version one more time, hope this will be the last time.

Sorry, to revise the chart version once again.

Shubham82 avatar Jan 20 '25 15:01 Shubham82

@Shubham82 No worries, I just rebased this PR :)

rbnis avatar Jan 22 '25 09:01 rbnis

Thanks @rbnis /lgtm

Shubham82 avatar Jan 22 '25 10:01 Shubham82

cc @gjtempleton, Need your approval to merge this PR.

Shubham82 avatar Jan 22 '25 10:01 Shubham82

/approve

gjtempleton avatar Jan 23 '25 00:01 gjtempleton

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, rbnis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 23 '25 00:01 k8s-ci-robot