autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Unable to find helm chart with clusterscaler version 1.25

Open nvithlani opened this issue 1 year ago • 11 comments

Which component are you using?: Cluster-autoscaler

cluster-autoscaler

What version of the component are you using?: 1.24

Component version: cluster autoscaler helm chart v9.27.0 (https://artifacthub.io/packages/helm/cluster-autoscaler/cluster-autoscaler/9.27.0)

What k8s version are you using (kubectl version)?:

kubectl version Output
$ kubectl version

kubectl version Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-02-16T12:38:05Z", GoVersion:"go1.17.7", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"25+", GitVersion:"v1.25.16-eks-77b1e4e", GitCommit:"c39acac7636499dd73442b62e11951592aedd1f8", GitTreeState:"clean", BuildDate:"2024-01-13T01:51:36Z", GoVersion:"go1.20.10", Compiler:"gc", Platform:"linux/amd64"} WARNING: version difference between client (1.23) and server (1.25) exceeds the supported minor version skew of +/-1

What environment is this in?: AWS

What did you expect to happen?: Expected to have a helm chart for cluster autoscaler v1.25, but the next version of the helm chart (9.28.0), but v9.28.0 contains autoscaler v1.26 which will be incompatible with our EKS v1.25

What happened instead?: Expected to have a helm chart for cluster autoscaler v1.25, but the next version of the helm chart (9.28.0), but v9.28.0 contains autoscaler v1.26 which will be incompatible with our EKS v1.25

We would like to upgrade our cluster autoscaler version to 1.25 using a helm chart How to reproduce it (as minimally and precisely as possible): The helm chart repo shows the app versions https://artifacthub.io/packages/helm/cluster-autoscaler/cluster-autoscaler/9.27.0 https://artifacthub.io/packages/helm/cluster-autoscaler/cluster-autoscaler/9.28.0

Anything else we need to know?: No

nvithlani avatar Jan 26 '24 19:01 nvithlani

I checked the helm chart versions, I think we missed it because cluster-autoscaler-chart-9.25.0 to cluster-autoscaler-chart-9.27.0 has app version 1.24.0 (CA version)

Shubham82 avatar Jan 29 '24 08:01 Shubham82

cc @gjtempleton PTAL

Shubham82 avatar Jan 29 '24 08:01 Shubham82

Hi @gjtempleton could you please take a look

Shubham82 avatar Feb 21 '24 09:02 Shubham82

/area helm-charts

Shubham82 avatar Feb 21 '24 09:02 Shubham82

I don't know what was the motivation behind jumping to 1.26 from 1.24, but it was done in https://github.com/kubernetes/autoscaler/pull/5651 (I think). Is it too late to update the appVersion to 1.25 in the release branch @Shubham82 ?

fmuyassarov avatar Feb 26 '24 10:02 fmuyassarov

@fmuyassarov Yeah, I agree with you, but it would be good to mention this thing under the README.md as a Note so that users can know about this. WDYT?

Shubham82 avatar Feb 26 '24 10:02 Shubham82

@fmuyassarov Yeah, I agree with you, but it would be good to mention this thing under the README.md as a Note so that users can know about this. WDYT?

Sorry did you mean that we can't update the appVersion to 1.25 for and cut a new patch release?

fmuyassarov avatar Feb 26 '24 19:02 fmuyassarov

@fmuyassarov, I mean if can't update the app version to the previous version then at least we have to mention this thing under the README.md as a note. The helm chart version or patch version is released whenever we update/add anything under the Charts. So suppose we change the app version to v1.25 (current app version v1.29.0) then the Chart release would be 9.36.0 (current chart version 9.35.0) and I don't think that is right.

@gjtempleton could you please take a look?

Shubham82 avatar Feb 27 '24 05:02 Shubham82

@fmuyassarov, I mean if can't update the app version to the previous version then at least we have to mention this thing under the README.md as a note. The helm chart version or patch version is released whenever we update/add anything under the Charts. So suppose we change the app version to v1.25 (current app version v1.29.0) then the Chart release would be 9.36.0 (current chart version 9.35.0) and I don't think that is right.

@gjtempleton could you please take a look?

Makes sense. But I wonder if release mechanism in the project could be improved to avoid such issues in the future.

fmuyassarov avatar Feb 28 '24 11:02 fmuyassarov

Hey,

This has historically been a gap in our release process for the CA, particularly when we release the new 1.X.0 version of the CA, there's currently no requirement/instructions to also release a new version of the Helm chart setting the app version & image tag to the new version of the CA.

I'm going to discuss with the rest of the release team and propose that we add this as the final step of cutting a first release for a new minor version of the CA starting with the 1.30.0 release.

gjtempleton avatar Mar 17 '24 11:03 gjtempleton

I'm going to discuss with the rest of the release team and propose that we add this as the final step of cutting a first release for a new minor version of the CA starting with the 1.30.0 release.

Thanks, @gjtempleton, It will be helpful if we release a new minor version of the Helm Chart at the time of releasing a minor version of CA.

Shubham82 avatar Mar 18 '24 11:03 Shubham82