autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Azure: add force delete option

Open Jont828 opened this issue 1 year ago • 16 comments

What type of PR is this?

/kind feature

What this PR does / why we need it: Add force delete option in Azure to the Helm chart and Azure autoscaler.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Azure: add force delete option

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Jont828 avatar Jan 09 '24 22:01 Jont828

You'll want to cut a new chart version (Chart.yaml) w/ these changes. I'd say that this warrants a minor bump.

jackfrancis avatar Jan 09 '24 22:01 jackfrancis

/assign @gandhipr

jackfrancis avatar Jan 09 '24 22:01 jackfrancis

Can we add some testing details performed?

gandhipr avatar Jan 09 '24 22:01 gandhipr

Sure, also forgot to mention this is still WIP

Jont828 avatar Jan 09 '24 22:01 Jont828

@gandhipr @jackfrancis Fixed unit tests, ready for final review pass before I squash.

Jont828 avatar Jan 16 '24 21:01 Jont828

/lgtm

gandhipr avatar Mar 12 '24 18:03 gandhipr

@Jont828 you'll need to bump the chart version (which will mean whichever of your PRs merges first will conflict with the other one that also needs a chart version bump, fyi)

jackfrancis avatar Mar 12 '24 22:03 jackfrancis

/test pull-cluster-autoscaler-e2e-azure

jackfrancis avatar Mar 19 '24 20:03 jackfrancis

/test ?

jackfrancis avatar Mar 19 '24 20:03 jackfrancis

@jackfrancis: The following commands are available to trigger optional jobs:

  • /test pull-cluster-autoscaler-e2e-azure

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 19 '24 20:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jont828 Once this PR has been reviewed and has the lgtm label, please ask for approval from gandhipr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 19 '24 21:03 k8s-ci-robot

/test pull-cluster-autoscaler-e2e-azure

jackfrancis avatar Mar 21 '24 22:03 jackfrancis

@jackfrancis @gandhipr Are we good to merge this?

Jont828 avatar Apr 29 '24 21:04 Jont828

Seems like something got lost here? I only see a fraction of the original changes.

jackfrancis avatar May 07 '24 22:05 jackfrancis

@jackfrancis We forgot to remove the commit containing force delete in #6447 so force delete actually got merged already. This is just a follow up to address comments and for consistency.

Jont828 avatar May 20 '24 17:05 Jont828

/remove-area helm-charts removing the /area helm-chart label as there are no changes/modifications by this PR (now) in the Charts directory.

Shubham82 avatar Jun 21 '24 10:06 Shubham82