autoscaler
autoscaler copied to clipboard
Azure: add force delete option
What type of PR is this?
/kind feature
What this PR does / why we need it: Add force delete option in Azure to the Helm chart and Azure autoscaler.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Azure: add force delete option
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
You'll want to cut a new chart version (Chart.yaml) w/ these changes. I'd say that this warrants a minor bump.
/assign @gandhipr
Can we add some testing details performed?
Sure, also forgot to mention this is still WIP
@gandhipr @jackfrancis Fixed unit tests, ready for final review pass before I squash.
/lgtm
@Jont828 you'll need to bump the chart version (which will mean whichever of your PRs merges first will conflict with the other one that also needs a chart version bump, fyi)
/test pull-cluster-autoscaler-e2e-azure
/test ?
@jackfrancis: The following commands are available to trigger optional jobs:
/test pull-cluster-autoscaler-e2e-azure
Use /test all to run all jobs.
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Jont828 Once this PR has been reviewed and has the lgtm label, please ask for approval from gandhipr. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test pull-cluster-autoscaler-e2e-azure
@jackfrancis @gandhipr Are we good to merge this?
Seems like something got lost here? I only see a fraction of the original changes.
@jackfrancis We forgot to remove the commit containing force delete in #6447 so force delete actually got merged already. This is just a follow up to address comments and for consistency.
/remove-area helm-charts
removing the /area helm-chart label as there are no changes/modifications by this PR (now) in the Charts directory.