autoscaler
autoscaler copied to clipboard
Addon-resizer-release-1.8 branch: Add repo root OWNERS file
What type of PR is this?
/kind cleanup
We don't currently have the same repo root OWNERS file as the default branch of the repo, meaning that approval is required from the addon-resizer OWNERS file, even for trivial changes such as #6400
What this PR does / why we need it:
Adds a new repo root level OWNERS file with the same contents as currently in the repo's default branch. I haven't touched/updated the OWNERS file for the addon-resizer though we should also update that in the near future.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gjtempleton, mwielgus
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mwielgus I think the /approve label didn't apply, could you please give it again, so that it will merge?
I think it's because we're in a catch-22 where there's not a root level OWNERS file on the branch as checked by prow, so there's no-one able to apply an approved label to set up the permissions going forward 👎
Think we'd need to bypass branch protections and force the merge via the UI to get it merged.
I think it's because we're in a catch-22 where there's not a root level OWNERS file on the branch as checked by prow, so there's no-one able to apply an approved label to set up the permissions going forward 👎
Think we'd need to bypass branch protections and force the merge via the UI to get it merged.
yeah, Agree with you @gjtempleton. I think we have only this option. Thanks for the information.
I think it's because we're in a catch-22 where there's not a root level OWNERS file on the branch as checked by prow, so there's no-one able to apply an approved label to set up the permissions going forward 👎
Think we'd need to bypass branch protections and force the merge via the UI to get it merged.
@mwielgus @gjtempleton can we merge this PR as per the above suggestion? if we can, so could you please merge this PR.