autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

cluster-autoscaler: update otelgrpc to v0.46.0 for SVM

Open grosser opened this issue 2 years ago • 5 comments

https://nvd.nist.gov/vuln/detail/CVE-2023-47108

Which component are you using?:

cluster-autoscaler

What version of the component are you using?:

master

HIGH	CVE-2023-47108	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc	0.45.0	0.46.0	GHSA-8pgv-569h-w5rw	COPY /go/autosc

updating to 0.45 works, but 0.46 breaks the build

grosser avatar Nov 15 '23 00:11 grosser

this seems to do the trick:

go mod edit -replace go.opentelemetry.io/otel/metric=go.opentelemetry.io/otel/[email protected]
go mod edit -replace go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc=go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/[email protected]
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected]

grosser avatar Nov 15 '23 00:11 grosser

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 13 '24 01:02 k8s-triage-robot

/remove-lifecycle stale

Shubham82 avatar Feb 20 '24 09:02 Shubham82

We're largely dependent on this being resolved upstream as it's a dependency we pull in when vendoring k/k: https://github.com/kubernetes/kubernetes/pull/121842

In addition, my reading of this is that we're at low/no risk of it being exploited as we only use the UnaryServerInterceptor in the externalgrpc cloudprovider implementation, and we don't appear to have a metrics pipeline configured for it? Or am I missing something?

gjtempleton avatar Mar 14 '24 14:03 gjtempleton

just our vuln scanner complaining and I would like to shut it up :D ... so yeah can wait until upstream fixes it, but would like to have it resolved eventually

grosser avatar Mar 14 '24 16:03 grosser