autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

fix(sec): upgrade github.com/opencontainers/runc to

Open chncaption opened this issue 2 years ago • 9 comments

What happened？

There are 1 security vulnerabilities found in github.com/opencontainers/runc v1.1.4

What did I do？

Upgrade github.com/opencontainers/runc from v1.1.4 to for vulnerability fix

What did you expect to happen？

Ideally, no insecure libs should be used.

The specification of the pull request

PR Specification from OSCS

chncaption avatar Aug 07 '23 10:08 chncaption

Welcome @chncaption!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 07 '23 10:08 k8s-ci-robot

@chncaption Maybe this PR is not merged due to a failed test i.e. Tests / test-and-verify (pull_request) which required to pass to merge this PR. The test failed with the following message: inconsistent vendoring in /home/runner/work/autoscaler/autoscaler/go/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e Please take a look at it.

Shubham82 avatar Aug 28 '23 11:08 Shubham82

cc @jbartosik

Shubham82 avatar Aug 28 '23 11:08 Shubham82

@chncaption Please address the failed test so that it will merge.

Shubham82 avatar Sep 04 '23 07:09 Shubham82

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chncaption, jbartosik, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 04 '23 08:09 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 02 '23 18:11 k8s-ci-robot

@chncaption Please resolve the merge conflicts and address the failed test so that it will merge.

Shubham82 avatar Nov 03 '23 07:11 Shubham82

@chncaption please address the failed test cases.

Shubham82 avatar Nov 15 '23 08:11 Shubham82

@chncaption Is there any progress on this PR?

Shubham82 avatar Jan 09 '24 08:01 Shubham82

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 08 '24 09:04 k8s-triage-robot

@chncaption are you working on this PR?, If yes Please resolve the failed test cases.

Shubham82 avatar Apr 08 '24 10:04 Shubham82

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 08 '24 10:05 k8s-triage-robot

Closing this PR, as no response from the author and also the current version of github.com/opencontainers/runc is v1.1.7 (https://github.com/kubernetes/autoscaler/blob/5ecf37aec8f3e6f3530ac9bda4d956893435e2d1/vertical-pod-autoscaler/e2e/go.mod#L94C2-L94C32), so the vulnerability is fixed now (IMO) Please reopen if you think it is relevant!

/close

Shubham82 avatar May 13 '24 09:05 Shubham82

@Shubham82: Closed this PR.

In response to this:

Closing this PR, as no response from the author and also the current version of github.com/opencontainers/runc is v1.1.7 (https://github.com/kubernetes/autoscaler/blob/5ecf37aec8f3e6f3530ac9bda4d956893435e2d1/vertical-pod-autoscaler/e2e/go.mod#L94C2-L94C32), so the vulnerability is fixed now (IMO) Please reopen if you think it is relevant!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 13 '24 09:05 k8s-ci-robot