CherryServer provider mentioned in the release notes for Cluster Autoscaler 1.24.0, but no actual support in release included

[zalmarge]

Which component are you using?: cluster-autoscaler

What version of the component are you using?: v1.24.0

Component version:

What k8s version are you using (kubectl version)?: v1.24.3

kubectl version Output

$ kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.3", GitCommit:"aef86a93758dc3cb2c658dd9657ab4ad4afc21cb", GitTreeState:"clean", BuildDate:"2022-07-13T14:30:46Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.3", GitCommit:"aef86a93758dc3cb2c658dd9657ab4ad4afc21cb", GitTreeState:"clean", BuildDate:"2022-07-13T14:23:26Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"linux/amd64"}

What environment is this in?: Ubuntu 20.04 LTS bare-metal servers at Cherry Servers

What did you expect to happen?:

As Cluster Autoscaler 1.24.0 release notes states that Cherry Servers provider has been added, I would expect it to be true.

What happened instead?:

Neither release sources, nor image k8s.gcr.io/autoscaling/cluster-autoscaler:v1.24.0 contain actual implementation for cherryservers cloud provider. From what I see, there's no implementation in Git branch cluster-autoscaler-release-1.24 too.

How to reproduce it (as minimally and precisely as possible):

# no cherryservers among available values
docker container run --rm k8s.gcr.io/autoscaling/cluster-autoscaler:v1.24.0 ./cluster-autoscaler --help 2>&1 | grep 'cloud-provider string'
      --cloud-provider string                                              Cloud provider type. Available values: [aws,azure,gce,alicloud,cloudstack,baiducloud,magnum,digitalocean,exoscale,huaweicloud,hetzner,oci,ovhcloud,clusterapi,ionoscloud,linode,bizflycloud,brightbox,packet,vultr,tencentcloud] (default "gce")

# no implementation in sources too
curl -sSL https://raw.githubusercontent.com/kubernetes/autoscaler/cluster-autoscaler-release-1.24/cluster-autoscaler/cloudprovider/cloud_provider.go  | grep cherryservers

Anything else we need to know?:

Do you have image with latest changes in master branch? k8s.gcr.io/autoscaling/cluster-autoscaler:latest or something alike?

[Shubham82]

Hi @zalmarge IMO the cloud provider cherry server was added after the CA v1.24.0 branch cut and not present in the /cluster-autoscaler-release-1.24 branch: https://github.com/kubernetes/autoscaler/tree/cluster-autoscaler-release-1.24/cluster-autoscaler/cloudprovider/builder

It is present in the master branch: https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider/builder

So it will be in the binary/image release for CA v1.25.

[Shubham82]

Hi @gjtempleton @MaciekPytel am I going right? WDYT?

Should we remove this thing from release notes?

[Shubham82]

@zalmarge you can make an image or build the code (from the master branch) by using Makefile. There is a make-image rule which builds the image for CA(master). The following steps are:

1. make make-image it creates the following docker image:

REPOSITORY                                          TAG
staging-k8s.gcr.io/cluster-autoscaler-amd64         dev

2. docker run --rm staging-k8s.gcr.io/cluster-autoscaler-amd64:dev ./cluster-autoscaler --help it will show cherryservers under `--cloud-provider string

--cloud-provider string Cloud provider type. Available values: [aws,azure,gce,alicloud,cherryservers,cloudstack,baiducloud,magnum,digitalocean,exoscale,externalgrpc,huaweicloud,hetzner,oci,ovhcloud,clusterapi,ionoscloud,linode,bizflycloud,brightbox,packet,vultr,tencentcloud] (default "gce")

Hope it will help you!

[gjtempleton]

Hey Shubham, yep, looks like you're correct and this was mistakenly included in the release notes for 1.24 despite not making it into that release branch, will update the release notes to remove this from 1.24.

[Shubham82]

thanks @gjtempleton

[Shubham82]

Hi @zalmarge JFYI: CherryServer has been removed from Cluster Autoscaler 1.24.0 release notes.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Shubham82]

CherryServer is now available in Cluster Autoscaler from version v1.25. Please see the release notes for CA v1.25

[Shubham82]

Closing this issue as it is resolved. /close

[k8s-ci-robot]

@Shubham82: Closing this issue.

In response to this:

Closing this issue as it is resolved. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.