autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

What is the best way to update VPA

Open AhmadMS1988 opened this issue 3 years ago • 4 comments

How can I update vpa without the need for ./hack/vpa-down.sh and ./hack/vpa-up.sh Because this will delete the existing vpa rules. Thank you

AhmadMS1988 avatar Apr 19 '22 11:04 AhmadMS1988

If I'm correct you can edit file before you do ./vpa-down.sh https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/hack/vpa-process-yamls.sh delete this crd from this file. ACTION=$1 COMPONENTS="vpa-v1-crd-gen vpa-rbac updater-deployment recommender-deployment admission-controller-deployment" case ${ACTION} in delete|diff|print) COMPONENTS+=" vpa-beta2-crd" ;; esac

because it is responsible for where data are stored. Then you can do ./vpa-up.sh with newer version of VPA.

Of course if there is no new changes in CRD between versions of VPA.

I'm not responsible for this project so please to be sure wait for @jbartosik . I tested it myself and I think it works properly but maybe there are some other dependencies somewhere.

aleksrosz avatar Jun 08 '22 12:06 aleksrosz

@jbartosik I checked again, and between vpa-release-0.10 and vpa-release-0.11 I don't see changes in CRD which are in file vpa-v1-crd.yaml and vpa-v1-crd-gen.yaml so IMHO, it is possible to do modifications like I mentioned above and migrate from 0.10 to 0.11 without losing rules and CPU, mem usage history. Can you confirm?

Maybe can I create PR to this readme about this https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/README.md ?

aleksrosz avatar Jul 26 '22 09:07 aleksrosz

#5061 is updating Readme?

jbartosik avatar Aug 01 '22 12:08 jbartosik

@jbartosik no. I decided to not put this information without your confirmation.

aleksrosz avatar Aug 01 '22 13:08 aleksrosz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 30 '22 13:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 29 '22 13:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Dec 29 '22 14:12 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 29 '22 14:12 k8s-ci-robot