(do not merge) use a single govmomi client within a container

[adikul30]

What this PR does / why we need it:

ListView feature uses a property collector to continuously listen to task updates. To prevent continuous reconnections, a separate VC client was used with the http.Timeout value set to 0. A separate client ends up creating a separate session with the VC.

To reduce sessions, we can use a single client throughout a container.

Session count wrt. vsphere-csi-controller replicas with this PR ->

3 replicas → 3 controller + 1 syncer = 4 sessions

2 replicas → 2 controller + 1 syncer = 3 sessions

1 replica → 1 controller + 1 syncer = 2 sessions

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done: In progress

Special notes for your reviewer:

Release note:

use a single govmomi client within a container to reduce sessions

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adikul30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [adikul30]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[svcbot-qecnsdp]

Started WCP block pre-checkin pipeline... Build Number: 1159

[svcbot-qecnsdp]

Build ID: 1159
WCP build status: FAILURE 
Stage before exit: null 
Jenkins E2E Test Results: 
FAIL! - Interrupted by User -- 0 Passed | 5 Failed | 0 Pending | 811 Skipped
--- FAIL: TestE2E (1263.44s)
FAIL

Ginkgo ran 1 suite in 22m6.544686677s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-wcp-precheckin/Results/1159/vsphere-csi-driver`

[svcbot-qecnsdp]

Started WCP block pre-checkin pipeline... Build Number: 1160

[svcbot-qecnsdp]

Build ID: 1160
WCP build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 

Ran 13 of 816 Specs in 2688.194 seconds
SUCCESS! -- 13 Passed | 0 Failed | 0 Pending | 803 Skipped
PASS

Ginkgo ran 1 suite in 46m16.362504452s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/csi-wcp-precheckin/Results/1160/vsphere-csi-driver`

[svcbot-qecnsdp]

Started WCP block pre-checkin pipeline... Build Number: 1202

[svcbot-qecnsdp]

Build ID: 1202
WCP build status: FAILURE 
Stage before exit: null 

[svcbot-qecnsdp]

Started WCP block pre-checkin pipeline... Build Number: 1210

[svcbot-qecnsdp]

Build ID: 1210
WCP build status: FAILURE 
Stage before exit: null 
Jenkins E2E Test Results: 
FAIL! -- 7 Passed | 6 Failed | 0 Pending | 796 Skipped
--- FAIL: TestE2E (3279.00s)
FAIL

Ginkgo ran 1 suite in 55m56.907843374s

Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-wcp-precheckin/Results/1210/vsphere-csi-driver`

[adikul30]

rebasing

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale