sig-storage-lib-external-provisioner icon indicating copy to clipboard operation
sig-storage-lib-external-provisioner copied to clipboard

reduce the volume name gap with external-provisioner

Open smileusd opened this issue 1 year ago • 2 comments

This pr is to reduce the gap with the external-provisioner pv name generation at https://github.com/kubernetes-csi/external-provisioner/blob/0f8b1662e25f37675da1f82acb78cd820b359419/pkg/controller/controller.go#L626 There is a potential bug if user not use default prefix or length to generate the pv name. There is a unexpected error.

/kind bug /sig storage

Reduce the volume name gap with external-provisioner

smileusd avatar Oct 23 '24 08:10 smileusd

Hi @smileusd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 23 '24 08:10 k8s-ci-robot

/ok-to-test

jsafrane avatar Nov 16 '24 17:11 jsafrane

/lgtm /approve Thanks for the patch!

jsafrane avatar Nov 16 '24 17:11 jsafrane

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, smileusd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 16 '24 17:11 k8s-ci-robot

@jsafrane Thank you!

smileusd avatar Nov 26 '24 07:11 smileusd