release-sdk icon indicating copy to clipboard operation
release-sdk copied to clipboard

Fix e2e workflow syntax

Open elsesiy opened this issue 1 year ago • 5 comments
trafficstars

The workflow syntax in #93 was incorrect, with is not allowed for run steps

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


elsesiy avatar Sep 03 '24 06:09 elsesiy

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsesiy Once this PR has been reviewed and has the lgtm label, please assign justaugustus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 03 '24 06:09 k8s-ci-robot

Hi @elsesiy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 03 '24 06:09 k8s-ci-robot

/ok-to-test

saschagrunert avatar Sep 03 '24 07:09 saschagrunert

@saschagrunert Since there is not semantic difference between the current signer initialization code and the previous implementation (ref) other than moving it to a helper func I don't think the current failure is related. Maybe the issuer regex is too restrictive?

elsesiy avatar Sep 09 '24 02:09 elsesiy

@elsesiy yeah it seems that the tests itself are broken somehow. :thinking:

saschagrunert avatar Sep 09 '24 07:09 saschagrunert

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 16 '25 06:01 k8s-triage-robot

/remove-lifecycle stale

elsesiy avatar Jan 22 '25 03:01 elsesiy

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Mar 04 '25 21:03 k8s-ci-robot

thanks

already fixed in #429

cpanato avatar Mar 05 '25 08:03 cpanato