Update to controller-runtime v0.16.3

[xrstf]

This bumps controller-runtime to 0.16.3, a version that ships with the same kube version (0.28.3) that is currently in-use in the CI environment.

The biggest changes are

• controller-runtime's fakeclient now supports field-selectors, but those have to be setup before the fakeclient is created.
• the fakeclient rejects adding objects that have a DeletionTimestamp without any finalizers
• wait.Poll is deprecated

I also re-structured the go.mod to have direct dependencies on top and all indirect dependencies at the bottom.

My biggest concern is that I don't know if the new caching setup is a) correct and b) requires more permissions or RBAC changes to work. :grimacing: Would need to deploy this somewhere to test it out.

[EDIT: I have since deployed crier and prow-controller-manager to an internal Prow and they worked just fine.]

This is part of https://github.com/kubernetes/test-infra/issues/32328

[k8s-ci-robot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[xrstf]

/test pull-prow-unit-test

[netlify[bot]]

✅ Deploy Preview for k8s-prow ready!

Name	Link
🔨 Latest commit	a8524ed5e358a51d6c0de4509725b8b6794b78c8
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-prow/deploys/66390c67a100830008b2ad2c
😎 Deploy Preview	https://deploy-preview-129--k8s-prow.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[xrstf]

This would be part of the efforts of kubernetes/test-infra#32328.

[xrstf]

/test pull-prow-unit-test

[xrstf]

/test all

[xrstf]

/test all

[xrstf]

/test all

[xrstf]

/hold

Unless someone(tm) is sure this works, we should not merge it.

[xrstf]

/hold cancel

I've deployed crier and the prow-controller-manager into our Prow and it seems to work just fine without any other changes.

[petr-muller]

/assign

I'm working my way through this

[xrstf]

Investigating why the integration tests now seemingly don't flake, but fail outright.

[xrstf]

I think I identified a flaking Deck test and I also think I found a good fix for it. Looking at the integration test's Prow history, I'm not sure why exactly the job began to flake more now.

[xrstf]

I've updated this to controller-runtime 0.16.5, the latest 0.16 that also still is based on exactly kube 0.28.3.

[midnightconman]

@petr-muller Can we merge this?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, petr-muller, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [petr-muller]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment