prow
prow copied to clipboard
kubernetes-sigs
doc: Update outdated hyperlinks in website
- Update links that point to
k/t-irepo to pointk-sigs/prowinstead (Note: Not all links that point tok/t-irepo have been updated, since many docs and codes are still ink/t-irepo.) - Update links that point to
*.mdfiles to Prow Doc website pages, if exist - http://github.com//tree//some.file → http://github.com//blob//some.file (this will remove unnecessary redirections on users' browser)
Before opening this PR, I checked whether links are OK using check-broken-links.sh.
(This PR Fixes #109.)
Hi @jihoon-seo. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Deploy Preview for k8s-prow ready!
| Name | Link |
|---|---|
| Latest commit | 638e46887ef2b0c5d2beb6ba59097680badcffaa |
| Latest deploy log | https://app.netlify.com/sites/k8s-prow/deploys/663556a0c7748c0008a2e3e7 |
| Deploy Preview | https://deploy-preview-103--k8s-prow.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jihoon-seo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
@cjwagner Thank you for your comment! I reflected your suggestions. PTAL!
/label tide/merge-method-squash /retest-required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The failure of pull-prow-integration & pull-prow-image-build-test seems to be related with
- https://github.com/kubernetes-sigs/prow/pull/101#issuecomment-2050263757
- https://github.com/kubernetes/test-infra/pull/32433
I guess that after #101 gets merged, additional updates (since paths of code are modified) & rebasing will be required for this PR.
I performed rebasing, reflecting code file path changes caused by #101.
Quoting @petr-muller's comment:
Let's wait a day or two though, for the case #101 needs to be reverted, so that we don't make it harder if needed.
Does anyone reviewing this PR believe they are in a position to approve soon?
In the future, it would be more efficient to contribute smaller PRs, focused on specific repo areas (e.g. code vs. site) as well as on the various topics that have been addressed. Thanks!
@airbornepony I see. You are right. Next time I will open smaller PRs. And if needed, I may exclude code changes from this PR.
@jihoon-seo Since nobody has responded affirming their ability to approve, feel free to assign to me, and I'll take the time to get this done.
Reviewers: If you have important concerns, please comment. Otherwise, let's avoid any nit/trivial comments in order to merge this PR in a timely way. Small follow-up PRs are always welcome. Thanks all!
I'm happy to stamp approved on PRs that get reviewed by others but don't have capacity to perform full reviews right now
I agree that we don't need to be perfect, I have no problem with letting improvements like this merge with possible issues fixed as a followup.
@airbornepony as per your comment, let me assign this PR to you: /assign @airbornepony Please take a look. Thank you!
@cjwagner @petr-muller @kb000 @airbornepony Thank you all for your reviews and comments!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: airbornepony, cjwagner, jihoon-seo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [cjwagner]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment