node-feature-discovery
node-feature-discovery copied to clipboard
kubernetes-sigs
fix topology-updater cpu report
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: AllenXu93 (913b34baddd78b75cf1b13ff7035dbe777165d2c)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @AllenXu93!
It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @AllenXu93. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | 913b34baddd78b75cf1b13ff7035dbe777165d2c |
| Latest deploy log | https://app.netlify.com/projects/kubernetes-sigs-nfd/deploys/6891ec9a993e5f000839e871 |
| Deploy Preview | https://deploy-preview-1979--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
/cc
Need to review the code before to comment :) While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?
While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?
We seem to have some as the tests failed. But yes, we should have specific test case for this scenario-
@AllenXu93 could you fix and update the tests?
While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?
We seem to have some as the tests failed. But yes, we should have specific test case for this scenario-
@AllenXu93 could you fix and update the tests?
ok I will fix in this week
Sorry to bother you, can you help to review this PR ?
@AllenXu93 any thoughts on these comments? https://github.com/kubernetes-sigs/node-feature-discovery/pull/1979#discussion_r1925199335
Sorry to bother you, can you help to review this PR ?
@AllenXu93 any thoughts on these comments? #1979 (comment)
The latest code is updated as you suggestion. I rename suggestion
Sorry to bother you, can you help to review this PR ?
@AllenXu93 any thoughts on these comments? #1979 (comment)
Updated the code just now
isIntegralGuaranteed := hasExclusiveCPUs(pod)
rename to :
isPodHasIntegralCPUs := podHasIntegralCPUs(pod)
Do you think these changes ok ?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
LGTM label has been added.
New changes are detected. LGTM label has been removed.
@ffromani Reslove a conflict, PTAL. https://github.com/kubernetes-sigs/node-feature-discovery/pull/1979/commits/5dab33b3ebe0cfd0e53289a4f1bb72a74bd58447
LGTM label has been added.
@AllenXu93 could you please rebase the PR and also squash the commits?
push again and squash the commits, PTAL
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AllenXu93, marquiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [marquiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added.