nfs-subdir-external-provisioner icon indicating copy to clipboard operation
nfs-subdir-external-provisioner copied to clipboard

Improvements to allow more advanced deployments such as Kerberized NFS support

Open ml0renz0 opened this issue 3 years ago • 3 comments

Support Kerberized NFS (krb5p) adding extraContainers, extraEnvVars, extraVolumes & extraVolumeMounts to allow more advanced deployments.

To support Kerberized NFS values.yaml may contain:

extraVolumes:
  - name: krb5-config
    configMap:
      name: kerberos-config
  - name: kcmsocket
    hostPath:
      path: /var/run/.heim_org.h5l.kcm-socket
      type: Socket
  - name: keytab
    secret:
      secretName: nfs-krb5-principal
      optional: false
      items:
      - key: nfs
        path: keytab
extraVolumeMounts:
  - name: kcmsocket
    mountPath: /var/run/.heim_org.h5l.kcm-socket
extraEnvVars:
  - name: KRB5CCNAME
    value: "KCM:"
extraContainers:
  - name: kinit
    image: kerberos:0.10.0
    env:
      - name: KRB5CCNAME
        value: "KCM:"
      - name: KERBEROS_RENEWAL_TIME
        value: "86400"
    command:
      - bash
      - -ec
      - |
        kinit -kt /secrets/keytab nfs-principal
        while true; do
          kinit -R
          sleep ${KERBEROS_RENEWAL_TIME}
        done
    volumeMounts:
      - name: krb5-config
        mountPath: /etc/krb5.conf
        subPath: krb5.conf
      - name: kcmsocket
        mountPath: /var/run/.heim_org.h5l.kcm-socket
      - name: keytab
        mountPath: /secrets
    lifecycle:
      preStop:
       exec:
         command: ["/usr/bin/kdestroy"]

This will allow to deploy a sidecar that manages the Kerberos ticket throughout NFS external subdir provisioner lifecycle.

ml0renz0 avatar Oct 14 '22 10:10 ml0renz0

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mlorenzo-stratio / name: Marcos Lorenzo (91f762dde95685b1b7fe92d8b4e4deae31cf71a8)

Welcome @mlorenzo-stratio!

It looks like this is your first PR to kubernetes-sigs/nfs-subdir-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-subdir-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Oct 14 '22 10:10 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mlorenzo-stratio Once this PR has been reviewed and has the lgtm label, please assign humblec for approval by writing /assign @humblec in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 14 '22 10:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 12 '23 11:01 k8s-triage-robot

/remove-lifecycle stale

ml0renz0 avatar Jan 13 '23 15:01 ml0renz0

/test all

ml0renz0 avatar Apr 11 '23 08:04 ml0renz0

@mlorenzo-stratio: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 11 '23 08:04 k8s-ci-robot

/cc

ml0renz0 avatar Apr 11 '23 08:04 ml0renz0

@mlorenzo-stratio: GitHub didn't allow me to request PR reviews from the following users: mlorenzo-stratio.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 11 '23 08:04 k8s-ci-robot

/cc

ml0renz0 avatar Apr 11 '23 08:04 ml0renz0

@mlorenzo-stratio: GitHub didn't allow me to request PR reviews from the following users: mlorenzo-stratio.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 11 '23 08:04 k8s-ci-robot

/cc @pohly

ml0renz0 avatar Apr 11 '23 08:04 ml0renz0

/auto-cc

ml0renz0 avatar Apr 11 '23 08:04 ml0renz0

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 10 '23 08:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 19 '24 03:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Feb 18 '24 03:02 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 18 '24 03:02 k8s-ci-robot