nfs-subdir-external-provisioner
nfs-subdir-external-provisioner copied to clipboard
kubernetes-sigs
better example for helm mountOptions
with current example --set nfs.mountOptions='nfsvers=3' I got error in helm:
Error: INSTALLATION FAILED: template: nfs-subdir-external-provisioner/templates/storageclass.yaml:28:19: executing "nfs-subdir-external-provisioner/templates/storageclass.yaml" at <.Values.nfs.mountOptions>: range can't iterate over nfsvers=3
helm.go:84: [debug] template: nfs-subdir-external-provisioner/templates/storageclass.yaml:28:19: executing "nfs-subdir-external-provisioner/templates/storageclass.yaml" at <.Values.nfs.mountOptions>: range can't iterate over nfsvers=3
INSTALLATION FAILED
this works better for me:
--set nfs.mountOptions={"nfsvers=3"}
or with other
--set nfs.mountOptions={"nolock\,nfsvers=3"}
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: TiloGit (f017beaf87b86b15c2e77638055f3c037b354cf3)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @TiloGit!
It looks like this is your first PR to kubernetes-sigs/nfs-subdir-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/nfs-subdir-external-provisioner has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: TiloGit
To complete the pull request process, please assign yonatankahana after the PR has been reviewed.
You can assign the PR to them by writing /assign @yonatankahana in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@TiloGit can you please also bump the charts version (https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/master/charts/nfs-subdir-external-provisioner/Chart.yaml#L6) to 4.0.17?
any change to the helm chart require version release (unless, the helm release workflow will fail)
@TiloGit can you please also bump the charts version (https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/master/charts/nfs-subdir-external-provisioner/Chart.yaml#L6) to
4.0.17? any change to the helm chart require version release (unless, the helm release workflow will fail)
done, do you need this also for readme changes?
@TiloGit can you please also bump the charts version (https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/master/charts/nfs-subdir-external-provisioner/Chart.yaml#L6) to
4.0.17? any change to the helm chart require version release (unless, the helm release workflow will fail)done, do you need this also for readme changes?
yes, even though, personally, i don't consider it a version - the github action does detects it as a change and require version bump. and it make some sense - the chart's README.md is part of the chart, its in the package, so... new version
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@TiloGit i still think its wrong to escape the comma there. the escape is true for command line but the examples are usually jsons and in this context there is no need to escape the comma.