kubernetes-sigs
revert naming of FlakeAttempts
premature change of naming, ginkgo v2 is not running when kubetest2 installed from scratch
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: GanjMonk (770b32d5ac2140906bf25bc13bdc10efe5fa86b1)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @GanjMonk!
It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @GanjMonk. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GanjMonk
Once this PR has been reviewed and has the lgtm label, please assign mushuee for approval by writing /assign @mushuee in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I think we can do better for this, like detecting the ginkgo binary version or something. We do need to work with Kubernetes development at HEAD as well as past release branches.
cc @chendave
I think we can do better for this, like detecting the ginkgo binary version or something.
+1, maybe a change like this one https://github.com/kubernetes/test-infra/pull/26250
We do need to work with Kubernetes development at HEAD as well as past release branches.
+1 too, the support for flakeAttempts will eventually gone with ginkgo v2, I am afraid this will break the test again at some time in the future.
thanks for the PR -- please check if antonio's solution works for you https://github.com/kubernetes-sigs/kubetest2/pull/206,
@GanjMonk: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/close Closing in favor of https://github.com/kubernetes-sigs/kubetest2/pull/206
@spiffxp: Closed this PR.
In response to this:
/close Closing in favor of https://github.com/kubernetes-sigs/kubetest2/pull/206
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.