kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

update kube-ovn to use v1.12.28

Open zbb88888 opened this issue 1 year ago • 11 comments

What type of PR is this?

/kind feature

  • update kube-ovn 1.12 to latest
  • expose more process args
  • fix yaml lint
  • separate k8s CRD, role, role binding, service account into different yamls

What this PR does / why we need it: [kube-ovn] update to v1.12.28

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[kube-ovn] update to v1.12.28

zbb88888 avatar Nov 19 '24 07:11 zbb88888

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: bobz965 / name: bobz965 (8e816c465080a67196483b39eafb4ed24be34182, d8e06e4ff3c58caffab3d42d3b6f39a6f809fb3b)

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bobz965 Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 19 '24 07:11 k8s-ci-robot

Welcome @bobz965!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Nov 19 '24 07:11 k8s-ci-robot

Hi @bobz965. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 19 '24 07:11 k8s-ci-robot

/ok-to-test

yankay avatar Nov 19 '24 08:11 yankay

/uncc

VannTen avatar Nov 19 '24 08:11 VannTen

HI @bobz965 The commits need to be Squashed .

yankay avatar Nov 26 '24 01:11 yankay

HI @bobz965 The commits need to be Squashed .

done

zbb88888 avatar Nov 26 '24 02:11 zbb88888

HI @bobz965 The commits need to be Squashed .

done

HI @bobz965

The PR changes lots of work than upgrading, So why not separate it into multi-PRs? It's better to fill in the PR description and release note.

yankay avatar Dec 02 '24 02:12 yankay

HI @bobz965 The commits need to be Squashed .

done

HI @bobz965

The PR changes lots of work than upgrading, So why not separate it into multi-PRs? It's better to fill in the PR description and release note.

I will keep this PR containing kube-ovn only

zbb88888 avatar Dec 02 '24 02:12 zbb88888

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 11 '25 23:02 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 13 '25 00:05 k8s-triage-robot