kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

feat/kube-vip-cloud-provider-autodeploy

Open chrxmvtik opened this issue 1 year ago • 6 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Kube VIP addon contains a setting that let us load-balance services (kube_vip_services_enabled: true), however to make it work, we need to deploy Kube VIP Cloud Provider manually when cluster is deployed.

In order to make this ready in the out of the box manner, I've added a possibility to deploy Cloud Provider that will include all required settings (just one variable actually).

It doesn't cost us much space and trouble, but makes more sense related to service loadbalancing setting that can be set like right now.

Does this PR introduce a user-facing change?:

User have possibility to set two new settings in addons (Line 263):

# Kube VIP Cloud Provider
kube_vip_cloud_provider_enabled: false
# Define your own IP Pools or leave empty {}
kube_vip_cloud_provider_ip_pools:
  cidr-global: 172.16.0.0/24
  cidr-default: 192.168.0.200/30,192.168.0.200/29
  range-development: 192.168.0.210-192.168.0.220
  cidr-ipv6: 2001::10/127

chrxmvtik avatar Mar 12 '24 19:03 chrxmvtik

Hi @chrxmvtik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 12 '24 19:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrxmvtik Once this PR has been reviewed and has the lgtm label, please assign cristicalin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 12 '24 19:03 k8s-ci-robot

/ok-to-test

yankay avatar Mar 14 '24 11:03 yankay

Nice addition! Will you be able to apply it for already deployed clusters?

tuxillo avatar Apr 04 '24 10:04 tuxillo

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 17 '24 22:05 k8s-ci-robot

Hello,

What is the status of this request ? When will it be merged into next release ?

Regards

jaxklag avatar Sep 17 '24 12:09 jaxklag

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 16 '24 13:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 15 '25 13:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Feb 14 '25 14:02 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 14 '25 14:02 k8s-ci-robot