Fix calicoctl failure on workers when peering with router

[cosandr]

What type of PR is this? /kind bug

What this PR does / why we need it:

Fixes calicoctl crashing on worker nodes when attempting to set local_as.

fatal: [k8s04]: FAILED! => {"attempts": 4, "changed": true, "cmd": ["/opt/bin/calicoctl.sh", "apply", "-f", "-"], "delta": "0:00:00.099705", "end": "2023-11-30 18:11:07.581359", "msg": "non-zero return code", "rc": 1, "start": "2023-11-30 18:11:07.481654", "stderr": "Failed to apply 'Node' resource: [connection is unauthorized: nodes \"k8s04\" is forbidden: User \"system:serviceaccount:kube-system:calico-cni-plugin\" cannot update resource \"nodes/status\" in API group \"\" at the cluster scope]", "stderr_lines": ["Failed to apply 'Node' resource: [connection is unauthorized: nodes \"k8s04\" is forbidden: User \"system:serviceaccount:kube-system:calico-cni-plugin\" cannot update resource \"nodes/status\" in API group \"\" at the cluster scope]"], "stdout": "", "stdout_lines": []}

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @cosandr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cosandr Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[yankay]

/ok-to-test

[floryut]

@cosandr Are you still available to check and make progress on this PR ?

[cosandr]

@cosandr Are you still available to check and make progress on this PR ?

I can rebase now and I'll see if I get some time this week to check if it's still required.

[cosandr]

@floryut I tried it today on master and I got the same error (which doesn't occur with this PR).

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.