kubernetes-sigs
- 🐛 (:bug:): bugfix Curl -s disables all output, including error output. As a result, when I run make install, I don't get the Kustomize binary, but there is no error, which is very unfriendly
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: kilsilent (6035224f0944edf9f6f7a11fef8cfd872391eab7)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @kilsilent!
It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @kilsilent. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @kilsilent ! Thanks for the contribution! I think this is a useful change but before we can continue with this PR we need a couple things:
- Before your PR can be accepted you will need to sign the CLA Authorization. I believe you may also need to sign your commits with the
-soption when runninggit commit. - The PR title is very long and doesn't quite match the PR title standards. Would you mind changing the title of the PR to something more along the lines of: :bug: (makefile):
make kustomizedoes not showcurlerror output
Once these are done, I would be happy to give it the ok-to-test label and work on getting this merged.
Hi @kilsilent ! Thanks for the contribution! I think this is a useful change but before we can continue with this PR we need a couple things:
- Before your PR can be accepted you will need to sign the CLA Authorization. I believe you may also need to sign your commits with the
-soption when runninggit commit.- The PR title is very long and doesn't quite match the PR title standards. Would you mind changing the title of the PR to something more along the lines of: 🐛 (makefile):
make kustomizedoes not showcurlerror outputOnce these are done, I would be happy to give it the ok-to-test label and work on getting this merged.
Thank you very much for your reply. I have completed the modification according to your suggestions
These changes are pretty straightforward and makes sense to me! Thanks for the contribution @kilsilent !
thanks
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: camilamacedo86, everettraven, kilsilent
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [camilamacedo86]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
It shows ok for me either 👍
Thank you for your contribution 🥇
Many Thanks
