kubernetes-sigs
✨ (go/v3) change the Dockerfile to allow built the Operator manager for different platforms
Currently the binary in the go/v3 scaffold template images is built using amd64 go arch. One of its motivations is to provide support for ppc64le and s390x arches.
Signed-off-by: Gilles Quillard [email protected]
- :x: - login: @gquillar / name: Gilles Quillard . The commit (ecd0bd7d8e3264fda7e3b977b8b1f7413a1f3686, 2b45ca4a0dbf9a627c5c29a5c04aa07cf59c0641) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @gquillar!
It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @gquillar. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gquillar
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval by writing /assign @camilamacedo86 in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
hi @camilamacedo86, Gilles has been out on sick leave, so I will be finishing out this PR. I rebased, and have filled out an EasyCLA application. is there anything else that needs to be done?
@camilamacedo86 I have rebased the PR and filled out the EasyCLA, but it is still showing that I haven't filled out EasyCLA. please advise
Hi @camilamacedo86 - is this PR made redundant by your work in https://github.com/kubernetes-sigs/kubebuilder/pull/2906?
Hi jaypoulz,
Hi @camilamacedo86 - is this PR made redundant by your work in https://github.com/kubernetes-sigs/kubebuilder/pull/2906?
This PR does not address properly the problem. So, acctually is the opposite. The work done https://github.com/kubernetes-sigs/kubebuilder/pull/2906 (which was also motivated by this PR) when merged would also close this one.
Perfect - yes - that's exactly what I was asking. :) We have an internal tracker for this PR, but I figured we might be able to close it in favor of #2906. Sounds like that is the case!
Hi @jaypoulz @gquillar,
Please, see the PR https://github.com/kubernetes-sigs/kubebuilder/pull/2906 and let us know if you would like to make any suggestions or if we win your lgtm as well. Your help on this is very appreciated.
hi @camilamacedo86, Gilles is still out on sick leave. I reviewed #2906, lgtm 👍 we can close this once that's merged and available