kube-scheduler-wasm-extension icon indicating copy to clipboard operation
kube-scheduler-wasm-extension copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Support `framework.Handle`

Open sanposhiho opened this issue 2 years ago • 25 comments

The scheduler exports framework.Handle to the plugins so that they can operate something on the framework side.

https://github.com/kubernetes/kubernetes/blob/add482a2d31db938f3dca87920313db9d1780cf5/pkg/scheduler/framework/interface.go#L601

Some functions don't need to be implemented though, we should support the common ones at least:

  • [ ] SnapshotSharedLister
  • [x] EventRecorder @Gekko0114 https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/83
  • [ ] RunFilterPluginsWithNominatedPods @chansuke
  • [ ] GetWaitingPod @chansuke
  • [x] RejectWaitingPod @Gekko0114 https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/98

sanposhiho avatar Oct 16 '23 01:10 sanposhiho

SnapshotSharedLister might not be needed if https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/issues/71 is complited, so lower priority for now.

sanposhiho avatar Dec 01 '23 12:12 sanposhiho

I will work on EventRecorder

Gekko0114 avatar Dec 03 '23 14:12 Gekko0114

/assign @Gekko0114

sanposhiho avatar Dec 03 '23 14:12 sanposhiho

@sanposhiho I would like to work on another one, do you have any recommendation? (which item has higher priority?)

Gekko0114 avatar Jan 18 '24 15:01 Gekko0114

I would say RunFilterPluginsWithNominatedPods is the one.

sanposhiho avatar Jan 19 '24 00:01 sanposhiho

Thanks, then I will work on RunFilterPluginsWithNominatedPods next

Gekko0114 avatar Jan 19 '24 01:01 Gekko0114

Since RunFilterPlugins is complicated, I will work on RejectWaitingPod instead

Gekko0114 avatar Jan 22 '24 13:01 Gekko0114

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 11 '24 04:05 k8s-triage-robot

/remove-lifecycle stale

sanposhiho avatar May 11 '24 09:05 sanposhiho

@sanposhiho @Gekko0114 I would like to contribute to this issue. I'm interested in GetWaitingPod, but could you please share the priority and current status? :pray: Or any recommendations?

chansuke avatar Jul 29 '24 03:07 chansuke

@chansuke This is just my impression, but I think GetWaitingPod is a good candidate because it's similar to rejectWaitingPod, which is already implemented. https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/98/files

Gekko0114 avatar Jul 29 '24 14:07 Gekko0114

@Gekko0114 Thank you so much for your comment. I'll take a look.

chansuke avatar Jul 29 '24 15:07 chansuke

/assign @chansuke

Thanks!

sanposhiho avatar Jul 30 '24 01:07 sanposhiho

/assign

Will pick up SnapshotSharedLister.

sanposhiho avatar Aug 04 '24 07:08 sanposhiho

/priority next-release Not all, but at least, SnapshotSharedLister is.

sanposhiho avatar Aug 07 '24 12:08 sanposhiho

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 05 '24 13:11 k8s-triage-robot

/remove-lifecycle stale

sanposhiho avatar Nov 05 '24 13:11 sanposhiho

@sanposhiho @Gekko0114 I'd like to work on RunFilterPluginsWithNominatedPods if no one is working.

chansuke avatar Nov 09 '24 09:11 chansuke

@chansuke 👍

sanposhiho avatar Nov 09 '24 09:11 sanposhiho

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 07 '25 10:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 09 '25 11:03 k8s-triage-robot